Copy dictionary keys and values in enumeration in TransferNamedProperties

Copy dictionary keys and values in enumeration in TransferNamedProperties

During bootstrapping when installing the global object we copy over the
properties from the snapshotted global object to the one created from a
provided template. Originally Genesis::TransferNamedProperties just iterated
over the entries, making the final order hash and thus platform dependent.
This CL fixes this by sorting the keys by enumeration index before copying them
to the destination object and thus making the key enumaration on the global
object platform independent.

Drive-by-fix: avoid crash when printing the global object during bootstrapping.

BUG=chromium:669029
Committed: https://crrev.com/7036eec6f7488e205c5583293e98e9f201d506b2
Cr-Commit-Position: refs/heads/master@{#41502}

[Camillo Bruni, 2016-11-29 08:51:25]

Description was changed from

==========
Copy dictionary keys and values in enumeration in TransferNamedProperties

During bootstrapping when installing the global object we copy over the
properties from the snapshotted global object to the one created from a
provided template. Originally Genesis::TransferNamedProperties just iterated
over the entries, making the final order hash and thus platform dependent.
This CL fixes this by sorting the keys by enumeration index before copying them
to the destination object and thus making the key enumaration on the global
object platform independent.

BUG=chromium:669029
==========

to

==========
Copy dictionary keys and values in enumeration in TransferNamedProperties

During bootstrapping when installing the global object we copy over the
properties from the snapshotted global object to the one created from a
provided template. Originally Genesis::TransferNamedProperties just iterated
over the entries, making the final order hash and thus platform dependent.
This CL fixes this by sorting the keys by enumeration index before copying them
to the destination object and thus making the key enumaration on the global
object platform independent.

Drive-by-fix: avoid crash when printing the global object during bootstrapping.

BUG=chromium:669029
==========

[Camillo Bruni, 2016-11-29 09:00:00]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 09:00:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Camillo Bruni, 2016-11-29 09:00:39]

cbruni@chromium.org changed reviewers:
+ ishell@chromium.org

[Camillo Bruni, 2016-11-29 09:00:39]

PTAL

[commit-bot: I haz the power, 2016-11-29 09:41:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 09:41:32]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-12-05 15:26:06]

https://codereview.chromium.org/2533223002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2533223002/diff/1/src/objects.cc#newcode18373
src/objects.cc:18373: Handle<FixedArray> Dictionary<Derived, Shape,
Key>::GetOrderedKeyIndices(
We already have Dictionary::BuildIterationIndicesArray() which does the same but
unlike this implementation allocates temporary array for storing decoded indices
and doesn't support deleted elements in GlobalDictionary.
Please choose and leave only one implementation.

[Camillo Bruni, 2016-12-05 16:23:59]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 16:24:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Camillo Bruni, 2016-12-05 16:33:07]

PTAL again.

[commit-bot: I haz the power, 2016-12-05 16:51:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 16:51:48]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-12-05 17:09:53]

lgtm

[Camillo Bruni, 2016-12-05 20:14:33]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2016-12-05 20:14:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 20:17:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480968873284780,
"parent_rev": "5d320d53b50870560b4b5c7894f728d9ceb3d308", "commit_rev":
"d36caad40c24da06cffaed8bf9e764c18602742d"}

[commit-bot: I haz the power, 2016-12-05 20:17:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-05 20:17:52]

Description was changed from

==========
Copy dictionary keys and values in enumeration in TransferNamedProperties

During bootstrapping when installing the global object we copy over the
properties from the snapshotted global object to the one created from a
provided template. Originally Genesis::TransferNamedProperties just iterated
over the entries, making the final order hash and thus platform dependent.
This CL fixes this by sorting the keys by enumeration index before copying them
to the destination object and thus making the key enumaration on the global
object platform independent.

Drive-by-fix: avoid crash when printing the global object during bootstrapping.

BUG=chromium:669029
==========

to

==========
Copy dictionary keys and values in enumeration in TransferNamedProperties

During bootstrapping when installing the global object we copy over the
properties from the snapshotted global object to the one created from a
provided template. Originally Genesis::TransferNamedProperties just iterated
over the entries, making the final order hash and thus platform dependent.
This CL fixes this by sorting the keys by enumeration index before copying them
to the destination object and thus making the key enumaration on the global
object platform independent.

Drive-by-fix: avoid crash when printing the global object during bootstrapping.

BUG=chromium:669029

Committed: https://crrev.com/7036eec6f7488e205c5583293e98e9f201d506b2
Cr-Commit-Position: refs/heads/master@{#41502}
==========

[commit-bot: I haz the power, 2016-12-05 20:17:53]

Patchset 2 (id:??) landed as
https://crrev.com/7036eec6f7488e205c5583293e98e9f201d506b2
Cr-Commit-Position: refs/heads/master@{#41502}