Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2533213006: Fixes coordinates supplied to WindowTreeHost (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes coordinates supplied to WindowTreeHost WindowTreeClient passes the event from the mus to WindowTreeHost. The coordinates of the event from mus are local to the target window. WindowTreeHost expects event relative to it's host window. So, before WindowTreeClient passes the event to WindowTreeHost it needs to convert. BUG=659155 TEST=covered by test R=sadrul@chromium.org Committed: https://crrev.com/da8533d0a7de36b72879edd0b8ac6728437a2ab0 Cr-Commit-Position: refs/heads/master@{#435440}

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -12 lines) Patch
M ui/aura/mus/window_port_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 chunk +12 lines, -1 line 1 comment Download
M ui/aura/mus/window_tree_client_unittest.cc View 2 chunks +15 lines, -5 lines 0 comments Download
M ui/aura/test/mus/test_window_tree.h View 1 3 chunks +10 lines, -2 lines 0 comments Download
M ui/aura/test/mus/test_window_tree.cc View 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sky
4 years ago (2016-11-30 21:12:37 UTC) #1
sadrul
lgtm https://codereview.chromium.org/2533213006/diff/20001/ui/aura/mus/window_tree_client.cc File ui/aura/mus/window_tree_client.cc (right): https://codereview.chromium.org/2533213006/diff/20001/ui/aura/mus/window_tree_client.cc#newcode1112 ui/aura/mus/window_tree_client.cc:1112: event->AsLocatedEvent()->set_location(host_location); This should update the root-location too I ...
4 years ago (2016-11-30 21:41:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533213006/20001
4 years ago (2016-11-30 22:08:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 22:13:42 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-30 22:18:13 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da8533d0a7de36b72879edd0b8ac6728437a2ab0
Cr-Commit-Position: refs/heads/master@{#435440}

Powered by Google App Engine
This is Rietveld 408576698