Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2533213002: Move core/editing/*Test.cpp to core/editing/BUILD.gn (Closed)

Created:
4 years ago by yosin_UTC9
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, Xiaocheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move core/editing/*Test.cpp to core/editing/BUILD.gn This patch moves "core/editing/*Test.cpp" to "core/editing/BUILD.gn" from "core/BUILD.gn" to reduce size of "core/BUILD.gn" and ease of adding new test for improving development experience. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/e2d021cbb3a6630d498d33527f264566df019cad Cr-Commit-Position: refs/heads/master@{#434943}

Patch Set 1 : 2016-11-29T17:42:48 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -40 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 2 chunks +1 line, -40 lines 0 comments Download
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
yosin_UTC9
PTAL
4 years ago (2016-11-29 09:22:33 UTC) #10
tkent
lgtm
4 years ago (2016-11-29 09:27:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533213002/20001
4 years ago (2016-11-29 09:28:21 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-11-29 10:09:33 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-29 10:11:37 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2d021cbb3a6630d498d33527f264566df019cad
Cr-Commit-Position: refs/heads/master@{#434943}

Powered by Google App Engine
This is Rietveld 408576698