New Tab Page: chrome-search://local-ntp/ files should not be cachable

New Tab Page: chrome-search://local-ntp/ files should not be cachable

Under chrome-search://local-ntp/, there is a file that can be modified
dynamically, e.g., config.js, and such a file should not be cachable
so that reload operations can load new data correctly.

This wasn't a problem before because Chrome's reload revalidates all
resources forcibly, but recent change made a normal reload revalidate
not all-resources, but only main resource.

BUG=668454
Committed: https://crrev.com/501ba310da88bd1b84202f3f4c9b38cc5e6ea899
Cr-Commit-Position: refs/heads/master@{#435166}

[Takashi Toyoshima, 2016-11-29 06:50:59]

Description was changed from

==========
New Tab Page: chrome-search://local-ntp/ files should not be cachable

Under chrome-search://local-ntp/, there is a file that can be modified
dynamically, e.g., config.js, and such a file should not be cachable
so that reload operations can load new data correctly.

This wasn't a problem before because Chrome's reload revalidates all
resources forcibly, but recent change made a normal reload revalidate
not all-resources, but only main resource.

BUG=668454
==========

to

==========
New Tab Page: chrome-search://local-ntp/ files should not be cachable

Under chrome-search://local-ntp/, there is a file that can be modified
dynamically, e.g., config.js, and such a file should not be cachable
so that reload operations can load new data correctly.

This wasn't a problem before because Chrome's reload revalidates all
resources forcibly, but recent change made a normal reload revalidate
not all-resources, but only main resource.

BUG=668454
==========

[Takashi Toyoshima, 2016-11-29 06:50:59]

toyoshim@chromium.org changed reviewers:
+ treib@chromium.org

[Takashi Toyoshima, 2016-11-29 06:51:10]

Can you take a look?

[Takashi Toyoshima, 2016-11-29 06:51:28]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 06:52:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 07:40:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 07:40:35]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-11-29 14:52:22]

lgtm

Thanks!

Could there be other URLDataSource implementations that (incorrectly) rely on
the old reload behavior? I guess if anything else broke, someone should have
noticed?

https://codereview.chromium.org/2533203002/diff/1/chrome/browser/search/local...
File chrome/browser/search/local_ntp_source.cc (right):

https://codereview.chromium.org/2533203002/diff/1/chrome/browser/search/local...
chrome/browser/search/local_ntp_source.cc:254: return false;
Could you add a comment about why this is necessary?

[Takashi Toyoshima, 2016-11-30 05:54:38]

I filed a new bug crbug.com/669776 to track similar regressions.
I will create a spreadsheet and ask authors if it could have a similar issue.

https://codereview.chromium.org/2533203002/diff/1/chrome/browser/search/local...
File chrome/browser/search/local_ntp_source.cc (right):

https://codereview.chromium.org/2533203002/diff/1/chrome/browser/search/local...
chrome/browser/search/local_ntp_source.cc:254: return false;
On 2016/11/29 14:52:22, Marc Treib wrote:
> Could you add a comment about why this is necessary?

Done.

[Takashi Toyoshima, 2016-11-30 05:55:37]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-11-30 05:55:37]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2533203002/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2016-11-30 05:56:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 08:26:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480485337191190,
"parent_rev": "5f301226eee456d187f7445529a76999f7b9a233", "commit_rev":
"81a763828f1a23a69348471cd54f365974bbf16d"}

[commit-bot: I haz the power, 2016-11-30 08:26:26]

Description was changed from

==========
New Tab Page: chrome-search://local-ntp/ files should not be cachable

Under chrome-search://local-ntp/, there is a file that can be modified
dynamically, e.g., config.js, and such a file should not be cachable
so that reload operations can load new data correctly.

This wasn't a problem before because Chrome's reload revalidates all
resources forcibly, but recent change made a normal reload revalidate
not all-resources, but only main resource.

BUG=668454
==========

to

==========
New Tab Page: chrome-search://local-ntp/ files should not be cachable

Under chrome-search://local-ntp/, there is a file that can be modified
dynamically, e.g., config.js, and such a file should not be cachable
so that reload operations can load new data correctly.

This wasn't a problem before because Chrome's reload revalidates all
resources forcibly, but recent change made a normal reload revalidate
not all-resources, but only main resource.

BUG=668454
==========

[commit-bot: I haz the power, 2016-11-30 08:26:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-30 08:28:13]

Description was changed from

==========
New Tab Page: chrome-search://local-ntp/ files should not be cachable

Under chrome-search://local-ntp/, there is a file that can be modified
dynamically, e.g., config.js, and such a file should not be cachable
so that reload operations can load new data correctly.

This wasn't a problem before because Chrome's reload revalidates all
resources forcibly, but recent change made a normal reload revalidate
not all-resources, but only main resource.

BUG=668454
==========

to

==========
New Tab Page: chrome-search://local-ntp/ files should not be cachable

Under chrome-search://local-ntp/, there is a file that can be modified
dynamically, e.g., config.js, and such a file should not be cachable
so that reload operations can load new data correctly.

This wasn't a problem before because Chrome's reload revalidates all
resources forcibly, but recent change made a normal reload revalidate
not all-resources, but only main resource.

BUG=668454

Committed: https://crrev.com/501ba310da88bd1b84202f3f4c9b38cc5e6ea899
Cr-Commit-Position: refs/heads/master@{#435166}
==========

[commit-bot: I haz the power, 2016-11-30 08:28:14]

Patchset 2 (id:??) landed as
https://crrev.com/501ba310da88bd1b84202f3f4c9b38cc5e6ea899
Cr-Commit-Position: refs/heads/master@{#435166}