Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2533193002: [Sync] Minor refactoring of DeviceInfoSyncBridgeTest. (Closed)

Created:
4 years ago by skym
Modified:
4 years ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Minor refactoring of DeviceInfoSyncBridgeTest. BUG= Committed: https://crrev.com/0dc4b5005bbdb0b98c576daef0fb251df98cb909 Cr-Commit-Position: refs/heads/master@{#435013}

Patch Set 1 #

Patch Set 2 : Removed used variable instead of hardcoded "ekn" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -103 lines) Patch
M components/sync/device_info/device_info_sync_bridge_unittest.cc View 1 20 chunks +106 lines, -103 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
skym
PTAL
4 years ago (2016-11-29 00:56:12 UTC) #3
maxbogue
lgtm
4 years ago (2016-11-29 01:29:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533193002/20001
4 years ago (2016-11-29 16:39:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 16:43:53 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-29 16:45:47 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0dc4b5005bbdb0b98c576daef0fb251df98cb909
Cr-Commit-Position: refs/heads/master@{#435013}

Powered by Google App Engine
This is Rietveld 408576698