Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: ui/ozone/platform/drm/gpu/screen_manager_unittest.cc

Issue 2533163002: ozone: Create GbmBuffers from fourcc formats and gbm flags. (Closed)
Patch Set: Address dnicoara's comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/platform/drm/gpu/screen_manager_unittest.cc
diff --git a/ui/ozone/platform/drm/gpu/screen_manager_unittest.cc b/ui/ozone/platform/drm/gpu/screen_manager_unittest.cc
index 5e009fddef2d81fe0b127d9c698a1edba8508b79..c35b3808ccbdf90115917cbcfea8eff747de4763 100644
--- a/ui/ozone/platform/drm/gpu/screen_manager_unittest.cc
+++ b/ui/ozone/platform/drm/gpu/screen_manager_unittest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <drm_fourcc.h>
#include <stddef.h>
#include <stdint.h>
@@ -499,7 +500,7 @@ TEST_F(ScreenManagerTest, EnableControllerWhenWindowHasBuffer) {
window->Initialize(buffer_generator_.get());
window->SetBounds(GetPrimaryBounds());
scoped_refptr<ui::ScanoutBuffer> buffer = buffer_generator_->Create(
- drm_, gfx::BufferFormat::BGRA_8888, GetPrimaryBounds().size());
+ drm_, DRM_FORMAT_XRGB8888, GetPrimaryBounds().size());
tfiga 2016/12/06 07:20:37 Shouldn't the new format be DRM_FORMAT_ARGB8888?
Daniele Castagna 2016/12/06 18:31:10 At this point Chrome doesn't support overlays with
window->SchedulePageFlip(
std::vector<ui::OverlayPlane>(1, ui::OverlayPlane(buffer)),
base::Bind(&EmptySwapCallback));
« ui/ozone/platform/drm/gpu/drm_thread.cc ('K') | « ui/ozone/platform/drm/gpu/screen_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698