Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: components/sync/engine/model_type_configurer.h

Issue 2533083002: [Sync] SyncEngine refactor part 1: interfaces. (Closed)
Patch Set: Rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/engine/fake_sync_engine.cc ('k') | components/sync/engine/model_type_configurer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/engine/model_type_configurer.h
diff --git a/components/sync/driver/backend_data_type_configurer.h b/components/sync/engine/model_type_configurer.h
similarity index 87%
rename from components/sync/driver/backend_data_type_configurer.h
rename to components/sync/engine/model_type_configurer.h
index dcd6ed751190184759eb80589c535b8c449b53c6..d1f943301d022b52ce5bdc8e2c9bfc22634d3d8c 100644
--- a/components/sync/driver/backend_data_type_configurer.h
+++ b/components/sync/engine/model_type_configurer.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef COMPONENTS_SYNC_DRIVER_BACKEND_DATA_TYPE_CONFIGURER_H_
-#define COMPONENTS_SYNC_DRIVER_BACKEND_DATA_TYPE_CONFIGURER_H_
+#ifndef COMPONENTS_SYNC_ENGINE_MODEL_TYPE_CONFIGURER_H_
+#define COMPONENTS_SYNC_ENGINE_MODEL_TYPE_CONFIGURER_H_
#include <map>
#include <memory>
@@ -21,7 +21,7 @@ struct ActivationContext;
// The DataTypeConfigurer interface abstracts out the action of
// configuring a set of new data types and cleaning up after a set of
// removed data types.
-class BackendDataTypeConfigurer {
+class ModelTypeConfigurer {
public:
enum DataTypeConfigState {
CONFIGURE_ACTIVE, // Actively being configured. Data of such types
@@ -46,11 +46,10 @@ class BackendDataTypeConfigurer {
// Returns: the set of types that are already configured and are ready to
// start.
//
- // TODO(akalin): Use a Delegate class with
- // OnConfigureSuccess/OnConfigureFailure/OnConfigureRetry instead of
- // a pair of callbacks. The awkward part is handling when
- // SyncBackendHost calls ConfigureDataTypes on itself to configure
- // Nigori.
+ // TODO(akalin): Use a Delegate class with OnConfigureSuccess,
+ // OnConfigureFailure, and OnConfigureRetry instead of a pair of callbacks.
+ // The awkward part is handling when SyncEngine calls ConfigureDataTypes on
+ // itself to configure Nigori.
virtual ModelTypeSet ConfigureDataTypes(
ConfigureReason reason,
const DataTypeConfigStateMap& config_state_map,
@@ -88,9 +87,9 @@ class BackendDataTypeConfigurer {
DataTypeConfigStateMap* state_map);
protected:
- virtual ~BackendDataTypeConfigurer() {}
+ virtual ~ModelTypeConfigurer() {}
};
} // namespace syncer
-#endif // COMPONENTS_SYNC_DRIVER_BACKEND_DATA_TYPE_CONFIGURER_H_
+#endif // COMPONENTS_SYNC_ENGINE_MODEL_TYPE_CONFIGURER_H_
« no previous file with comments | « components/sync/engine/fake_sync_engine.cc ('k') | components/sync/engine/model_type_configurer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698