Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: components/browser_sync/profile_sync_service_startup_unittest.cc

Issue 2533083002: [Sync] SyncEngine refactor part 1: interfaces. (Closed)
Patch Set: Rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/profile_sync_service_startup_unittest.cc
diff --git a/components/browser_sync/profile_sync_service_startup_unittest.cc b/components/browser_sync/profile_sync_service_startup_unittest.cc
index 8a421875e112b03a736b8f16dd26e811ed562778..61192bdbcbc665d11b295caa1351908e62fb0b67 100644
--- a/components/browser_sync/profile_sync_service_startup_unittest.cc
+++ b/components/browser_sync/profile_sync_service_startup_unittest.cc
@@ -18,9 +18,9 @@
#include "components/sync/base/pref_names.h"
#include "components/sync/driver/data_type_manager_mock.h"
#include "components/sync/driver/fake_data_type_controller.h"
-#include "components/sync/driver/glue/sync_backend_host_mock.h"
#include "components/sync/driver/sync_api_component_factory_mock.h"
#include "components/sync/driver/sync_service_observer.h"
+#include "components/sync/engine/fake_sync_engine.h"
#include "components/sync_preferences/pref_service_syncable.h"
#include "google_apis/gaia/gaia_auth_consumer.h"
#include "google_apis/gaia/gaia_constants.h"
@@ -30,7 +30,7 @@
using syncer::DataTypeManager;
using syncer::DataTypeManagerMock;
-using syncer::SyncBackendHostMock;
+using syncer::FakeSyncEngine;
using testing::_;
using testing::AnyNumber;
using testing::DoAll;
@@ -136,9 +136,9 @@ class ProfileSyncServiceStartupTest : public testing::Test {
return data_type_manager;
}
- SyncBackendHostMock* SetUpSyncBackendHost() {
- SyncBackendHostMock* sync_backend_host = new SyncBackendHostMock();
- EXPECT_CALL(*component_factory_, CreateSyncBackendHost(_, _, _, _))
+ FakeSyncEngine* SetUpSyncEngine() {
+ FakeSyncEngine* sync_backend_host = new FakeSyncEngine();
+ EXPECT_CALL(*component_factory_, CreateSyncEngine(_, _, _, _))
.WillOnce(Return(sync_backend_host));
return sync_backend_host;
}
@@ -169,7 +169,7 @@ TEST_F(ProfileSyncServiceStartupTest, StartFirstTime) {
// We've never completed startup.
pref_service()->ClearPref(syncer::prefs::kSyncFirstSetupComplete);
CreateSyncService(ProfileSyncService::MANUAL_START);
- SetUpSyncBackendHost();
+ SetUpSyncEngine();
DataTypeManagerMock* data_type_manager = SetUpDataTypeManager();
EXPECT_CALL(*data_type_manager, Configure(_, _)).Times(0);
@@ -243,7 +243,7 @@ TEST_F(ProfileSyncServiceStartupTest, DISABLED_StartNoCredentials) {
TEST_F(ProfileSyncServiceStartupTest, DISABLED_StartInvalidCredentials) {
CreateSyncService(ProfileSyncService::MANUAL_START);
std::string account_id = SimulateTestUserSignin(sync_service_.get());
- SyncBackendHostMock* mock_sbh = SetUpSyncBackendHost();
+ FakeSyncEngine* mock_sbh = SetUpSyncEngine();
// Tell the backend to stall while downloading control types (simulating an
// auth error).
@@ -277,7 +277,7 @@ TEST_F(ProfileSyncServiceStartupTest, DISABLED_StartInvalidCredentials) {
TEST_F(ProfileSyncServiceStartupCrosTest, StartCrosNoCredentials) {
EXPECT_CALL(*component_factory_, CreateDataTypeManager(_, _, _, _, _))
.Times(0);
- EXPECT_CALL(*component_factory_, CreateSyncBackendHost(_, _, _, _)).Times(0);
+ EXPECT_CALL(*component_factory_, CreateSyncEngine(_, _, _, _)).Times(0);
pref_service()->ClearPref(syncer::prefs::kSyncFirstSetupComplete);
EXPECT_CALL(observer_, OnStateChanged()).Times(AnyNumber());
@@ -291,7 +291,7 @@ TEST_F(ProfileSyncServiceStartupCrosTest, StartCrosNoCredentials) {
}
TEST_F(ProfileSyncServiceStartupCrosTest, StartFirstTime) {
- SetUpSyncBackendHost();
+ SetUpSyncEngine();
DataTypeManagerMock* data_type_manager = SetUpDataTypeManager();
pref_service()->ClearPref(syncer::prefs::kSyncFirstSetupComplete);
EXPECT_CALL(*data_type_manager, Configure(_, _));
@@ -312,7 +312,7 @@ TEST_F(ProfileSyncServiceStartupTest, StartNormal) {
CreateSyncService(ProfileSyncService::MANUAL_START);
std::string account_id = SimulateTestUserSignin(sync_service_.get());
sync_service_->SetFirstSetupComplete();
- SetUpSyncBackendHost();
+ SetUpSyncEngine();
DataTypeManagerMock* data_type_manager = SetUpDataTypeManager();
EXPECT_CALL(*data_type_manager, Configure(_, _));
EXPECT_CALL(*data_type_manager, state())
@@ -342,7 +342,7 @@ TEST_F(ProfileSyncServiceStartupTest, StartRecoverDatatypePrefs) {
CreateSyncService(ProfileSyncService::MANUAL_START);
std::string account_id = SimulateTestUserSignin(sync_service_.get());
sync_service_->SetFirstSetupComplete();
- SetUpSyncBackendHost();
+ SetUpSyncEngine();
DataTypeManagerMock* data_type_manager = SetUpDataTypeManager();
EXPECT_CALL(*data_type_manager, Configure(_, _));
EXPECT_CALL(*data_type_manager, state())
@@ -368,7 +368,7 @@ TEST_F(ProfileSyncServiceStartupTest, StartDontRecoverDatatypePrefs) {
CreateSyncService(ProfileSyncService::MANUAL_START);
std::string account_id = SimulateTestUserSignin(sync_service_.get());
sync_service_->SetFirstSetupComplete();
- SetUpSyncBackendHost();
+ SetUpSyncEngine();
DataTypeManagerMock* data_type_manager = SetUpDataTypeManager();
EXPECT_CALL(*data_type_manager, Configure(_, _));
EXPECT_CALL(*data_type_manager, state())
@@ -400,7 +400,7 @@ TEST_F(ProfileSyncServiceStartupTest, SwitchManaged) {
CreateSyncService(ProfileSyncService::MANUAL_START);
std::string account_id = SimulateTestUserSignin(sync_service_.get());
sync_service_->SetFirstSetupComplete();
- SetUpSyncBackendHost();
+ SetUpSyncEngine();
DataTypeManagerMock* data_type_manager = SetUpDataTypeManager();
EXPECT_CALL(*data_type_manager, Configure(_, _));
EXPECT_CALL(*data_type_manager, state())
@@ -435,7 +435,7 @@ TEST_F(ProfileSyncServiceStartupTest, StartFailure) {
CreateSyncService(ProfileSyncService::MANUAL_START);
std::string account_id = SimulateTestUserSignin(sync_service_.get());
sync_service_->SetFirstSetupComplete();
- SetUpSyncBackendHost();
+ SetUpSyncEngine();
DataTypeManagerMock* data_type_manager = SetUpDataTypeManager();
DataTypeManager::ConfigureStatus status = DataTypeManager::ABORTED;
DataTypeManager::ConfigureResult result(status, syncer::ModelTypeSet());
@@ -459,7 +459,7 @@ TEST_F(ProfileSyncServiceStartupTest, StartDownloadFailed) {
// Pre load the tokens
CreateSyncService(ProfileSyncService::MANUAL_START);
std::string account_id = SimulateTestUserSignin(sync_service_.get());
- SyncBackendHostMock* mock_sbh = SetUpSyncBackendHost();
+ FakeSyncEngine* mock_sbh = SetUpSyncEngine();
mock_sbh->set_fail_initial_download(true);
pref_service()->ClearPref(syncer::prefs::kSyncFirstSetupComplete);
« no previous file with comments | « components/browser_sync/profile_sync_service_mock.h ('k') | components/browser_sync/profile_sync_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698