[Sync] SyncEngine refactor part 1: interfaces.

components/sync/driver/sync_service.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SYNC_DRIVER_SYNC_SERVICE_H_
 #define COMPONENTS_SYNC_DRIVER_SYNC_SERVICE_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 182 matching lines @@
   // Used by tests.
   virtual bool IsSetupInProgress() const = 0;
 
   // Whether the data types active for the current mode have finished
   // configuration.
   virtual bool ConfigurationDone() const = 0;
 
   virtual const GoogleServiceAuthError& GetAuthError() const = 0;
   virtual bool HasUnrecoverableError() const = 0;
 
-  // Returns true if the SyncBackendHost has told us it's ready to accept
-  // changes. This should only be used for sync's internal configuration logic
-  // (such as deciding when to prompt for an encryption passphrase).
+  // Returns true if the SyncEngine has told us it's ready to accept changes.

[skym, 2016/12/02 20:54:55]

SyncEngine actually works great here. Could probably get away with "sync engine"
instead as well if you wanted. Mentioning how SyncService is implemented isn't
precisely the job of this interface, I think.

[maxbogue, 2016/12/02 23:59:27]

Removed the second sentence.

+  // This should only be used for sync's internal configuration logic (such as
+  // deciding when to prompt for an encryption passphrase).
   virtual bool IsBackendInitialized() const = 0;
 
   // Return the active OpenTabsUIDelegate. If open/proxy tabs is not enabled or
   // not currently syncing, returns nullptr.
   virtual sync_sessions::OpenTabsUIDelegate* GetOpenTabsUIDelegate() = 0;
 
   // Returns true if OnPassphraseRequired has been called for decryption and
   // we have an encrypted data type enabled.
   virtual bool IsPassphraseRequiredForDecryption() const = 0;
 
@@ skipping 112 matching lines @@
  protected:
   SyncService() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SyncService);
 };
 
 }  // namespace syncer
 
 #endif  // COMPONENTS_SYNC_DRIVER_SYNC_SERVICE_H_