[Sync] SyncEngine refactor part 1: interfaces.

components/sync/driver/sync_api_component_factory.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SYNC_DRIVER_SYNC_API_COMPONENT_FACTORY_H_
 #define COMPONENTS_SYNC_DRIVER_SYNC_API_COMPONENT_FACTORY_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 14 matching lines @@
 
 namespace syncer {
 
 class AssociatorInterface;
 class ChangeProcessor;
 class DataTypeDebugInfoListener;
 class DataTypeEncryptionHandler;
 class DataTypeManager;
 class DataTypeManagerObserver;
 class LocalDeviceInfoProvider;
-class SyncBackendHost;
+class SyncEngine;
 class SyncClient;
 class SyncPrefs;
 class SyncService;
 class SyncableService;
 struct UserShare;
 
 // This factory provides sync driver code with the model type specific sync/api
 // service (like SyncableService) implementations.
 class SyncApiComponentFactory {
  public:
@@ skipping 25 matching lines @@
     ChangeProcessor* change_processor;
     SyncComponents(AssociatorInterface* ma, ChangeProcessor* cp)
         : model_associator(ma), change_processor(cp) {}
   };
 
   // Creates and registers enabled datatypes with the provided SyncClient.
   virtual void RegisterDataTypes(
       SyncService* sync_service,
       const RegisterDataTypesMethod& register_platform_types_method) = 0;
 
-  // Instantiates a new DataTypeManager with a SyncBackendHost, a list of data
+  // Instantiates a new DataTypeManager with a SyncEngine, a list of data

[skym, 2016/12/02 20:54:54]

This is kind of stating the obvious. Yes, we know it takes a SyncEngine and a
DataTypeManagerObserser, those are literally the arguments below. Doesn't
actually take a list of DTCs, but actually a map. Might be valuable to just
remove the first sentence here.

[maxbogue, 2016/12/02 23:59:27]

Done.

   // type controllers and a DataTypeManagerObserver.  The return pointer is
   // owned by the caller.
   virtual DataTypeManager* CreateDataTypeManager(
       const WeakHandle<DataTypeDebugInfoListener>& debug_info_listener,
       const DataTypeController::TypeMap* controllers,
       const DataTypeEncryptionHandler* encryption_handler,
-      SyncBackendHost* backend,
+      SyncEngine* engine,
       DataTypeManagerObserver* observer) = 0;
 
   // Creating this in the factory helps us mock it out in testing.
-  virtual SyncBackendHost* CreateSyncBackendHost(
+  virtual SyncEngine* CreateSyncEngine(
       const std::string& name,
       invalidation::InvalidationService* invalidator,
       const base::WeakPtr<SyncPrefs>& sync_prefs,
       const base::FilePath& sync_folder) = 0;
 
   // Creating this in the factory helps us mock it out in testing.
   virtual std::unique_ptr<LocalDeviceInfoProvider>
   CreateLocalDeviceInfoProvider() = 0;
 
   // Legacy datatypes that need to be converted to the SyncableService API.
@@ skipping 16 matching lines @@
       std::unique_ptr<AttachmentStoreForSync> attachment_store,
       const UserShare& user_share,
       const std::string& store_birthday,
       ModelType model_type,
       AttachmentService::Delegate* delegate) = 0;
 };
 
 }  // namespace syncer
 
 #endif  // COMPONENTS_SYNC_DRIVER_SYNC_API_COMPONENT_FACTORY_H_