Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2533073003: [DevTools] Remove workspace-test.js part1. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove workspace-test.js part1. This test harness is slowing us down, so we are migrating away from it. BUG=none Committed: https://crrev.com/2a2b2c36e69180578a1c8e5a4348977f553e9426 Cr-Commit-Position: refs/heads/master@{#434840}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -232 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/edit-css-with-source-url.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +45 lines, -0 lines 2 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-do-not-bind-dirty-sourcecode.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-go-to-file-dialog.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-go-to-file-dialog-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator-expected.txt View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-nodejs.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-opens-network-uisourcecode.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-tabs-order.html View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/resources/example.css View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-in-files.html View 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-in-files-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects.html View 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html View 1 chunk +22 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-stack-in-errors.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/file-system-project.html View 6 chunks +29 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/jump-to-previous-editing-location.html View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/jump-to-previous-editing-location-expected.txt View 3 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dynamic-scripts-breakpoints.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/nodejs-set-breakpoint.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context-expected.txt View 1 chunk +19 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/switch-file.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/dynamic-script-tag.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-live-edit.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/network-uisourcecode-provider.html View 1 chunk +74 lines, -97 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/network-uisourcecode-provider-expected.txt View 1 chunk +27 lines, -13 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/style1.css View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/sources-panel-extension-names.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/workspace-mapping.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
dgozman
Take a look please.
4 years ago (2016-11-29 00:11:05 UTC) #2
lushnikov
lgtm! Didn't you forget to actually remove workspace-test.js? https://codereview.chromium.org/2533073003/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js (right): https://codereview.chromium.org/2533073003/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js#newcode445 third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js:445: { ...
4 years ago (2016-11-29 00:27:21 UTC) #3
dgozman
> Didn't you forget to actually remove workspace-test.js? I'm not done yet, hence the part1. ...
4 years ago (2016-11-29 00:33:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2533073003/1
4 years ago (2016-11-29 00:34:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 02:42:31 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-29 02:44:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a2b2c36e69180578a1c8e5a4348977f553e9426
Cr-Commit-Position: refs/heads/master@{#434840}

Powered by Google App Engine
This is Rietveld 408576698