Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2533073002:
[Presentation API] Throw NotAllowedError instead of AbortError when user closes MR dialog (Closed)
Description[Presentation API] Throw NotAllowedError instead of AbortError when user closes MR dialog
To fix web platform test: http://w3c-test.org/presentation-api/controlling-ua/startNewPresentation_displaynotallowed-manual.html
According to spec, reject promise with "NotAllowedError" if user denies permission to use a display (Step 12: https://w3c.github.io/presentation-api/#dfn-start-a-presentation-connection)
BUG=669273
Committed: https://crrev.com/942907a6114aadcf231cb66bd72fdaa16eacc583
Cr-Commit-Position: refs/heads/master@{#435399}
Patch Set 1 #
Messages
Total messages: 24 (14 generated)
zhaobin@chromium.org changed reviewers: + avayvod@chromium.org, imcheng@chromium.org, mfoltz@chromium.org
Description was changed from ========== [Presentation API] Throw NotAllowedError instead of AbortError when user closes MR dialog To fix web platform test: http://w3c-test.org/presentation-api/controlling-ua/startNewPresentation_disp... According to spec, reject promise with "NotAllowedError" if user denies permission to use a display (Step 12: https://w3c.github.io/presentation-api/#dfn-start-a-presentation-connection) BUG= ========== to ========== [Presentation API] Throw NotAllowedError instead of AbortError when user closes MR dialog To fix web platform test: http://w3c-test.org/presentation-api/controlling-ua/startNewPresentation_disp... According to spec, reject promise with "NotAllowedError" if user denies permission to use a display (Step 12: https://w3c.github.io/presentation-api/#dfn-start-a-presentation-connection) BUG=669273 ==========
I'm pretty sure the Cast SDK's requestSession counts on AbortError to be thrown to distinguish when the user closes dialog vs. when establishing the session failed. Have you coordinated this change with Vadim (vadimgo@)?
lgtm
On 2016/11/29 01:35:57, whywhat_OOO_till_Mon_Nov_28 wrote: > I'm pretty sure the Cast SDK's requestSession counts on AbortError to be thrown > to distinguish when the user closes dialog vs. when establishing the session > failed. Have you coordinated this change with Vadim (vadimgo@)? Created a CR updates Cast SDK: https://critique.corp.google.com/#review/140427257
On 2016/11/29 at 02:20:22, zhaobin wrote: > On 2016/11/29 01:35:57, whywhat_OOO_till_Mon_Nov_28 wrote: > > I'm pretty sure the Cast SDK's requestSession counts on AbortError to be thrown > > to distinguish when the user closes dialog vs. when establishing the session > > failed. Have you coordinated this change with Vadim (vadimgo@)? > > Created a CR updates Cast SDK: https://critique.corp.google.com/#review/140427257 Thanks! Looks good!
lgtm
The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zhaobin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480537195724660, "parent_rev":
"da0c589e9dbbef16f576bd817af83c1771835623", "commit_rev":
"58c9d4ae3fdde5b84e499665c140cb59834e6d92"}
Message was sent while issue was closed.
Description was changed from ========== [Presentation API] Throw NotAllowedError instead of AbortError when user closes MR dialog To fix web platform test: http://w3c-test.org/presentation-api/controlling-ua/startNewPresentation_disp... According to spec, reject promise with "NotAllowedError" if user denies permission to use a display (Step 12: https://w3c.github.io/presentation-api/#dfn-start-a-presentation-connection) BUG=669273 ========== to ========== [Presentation API] Throw NotAllowedError instead of AbortError when user closes MR dialog To fix web platform test: http://w3c-test.org/presentation-api/controlling-ua/startNewPresentation_disp... According to spec, reject promise with "NotAllowedError" if user denies permission to use a display (Step 12: https://w3c.github.io/presentation-api/#dfn-start-a-presentation-connection) BUG=669273 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Presentation API] Throw NotAllowedError instead of AbortError when user closes MR dialog To fix web platform test: http://w3c-test.org/presentation-api/controlling-ua/startNewPresentation_disp... According to spec, reject promise with "NotAllowedError" if user denies permission to use a display (Step 12: https://w3c.github.io/presentation-api/#dfn-start-a-presentation-connection) BUG=669273 ========== to ========== [Presentation API] Throw NotAllowedError instead of AbortError when user closes MR dialog To fix web platform test: http://w3c-test.org/presentation-api/controlling-ua/startNewPresentation_disp... According to spec, reject promise with "NotAllowedError" if user denies permission to use a display (Step 12: https://w3c.github.io/presentation-api/#dfn-start-a-presentation-connection) BUG=669273 Committed: https://crrev.com/942907a6114aadcf231cb66bd72fdaa16eacc583 Cr-Commit-Position: refs/heads/master@{#435399} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/942907a6114aadcf231cb66bd72fdaa16eacc583 Cr-Commit-Position: refs/heads/master@{#435399} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
