Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: net/socket/websocket_transport_client_socket_pool.cc

Issue 2533063002: Fix Net.Socket.IdleSocketTimeSaving histogram (Closed)
Patch Set: self review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/websocket_transport_client_socket_pool.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/websocket_transport_client_socket_pool.cc
diff --git a/net/socket/websocket_transport_client_socket_pool.cc b/net/socket/websocket_transport_client_socket_pool.cc
index 987723c2032965b70a060b6686aa28ba66ad4c19..babaef010fa800d093fcb0abea37ce5f85e4634e 100644
--- a/net/socket/websocket_transport_client_socket_pool.cc
+++ b/net/socket/websocket_transport_client_socket_pool.cc
@@ -397,7 +397,8 @@ void WebSocketTransportClientSocketPool::CancelRequest(
return;
std::unique_ptr<StreamSocket> socket = handle->PassSocket();
if (socket)
- ReleaseSocket(handle->group_name(), std::move(socket), handle->id());
+ ReleaseSocket(handle->group_name(), std::move(socket), handle->id(),
+ handle->connect_timing());
if (!DeleteJob(handle))
pending_callbacks_.erase(handle);
@@ -407,7 +408,8 @@ void WebSocketTransportClientSocketPool::CancelRequest(
void WebSocketTransportClientSocketPool::ReleaseSocket(
const std::string& group_name,
std::unique_ptr<StreamSocket> socket,
- int id) {
+ int id,
+ const LoadTimingInfo::ConnectTiming& connect_timing) {
WebSocketEndpointLockManager::GetInstance()->UnlockSocket(socket.get());
CHECK_GT(handed_out_socket_count_, 0);
--handed_out_socket_count_;
« no previous file with comments | « net/socket/websocket_transport_client_socket_pool.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698