Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2224)

Unified Diff: net/socket/socket_test_util.cc

Issue 2533063002: Fix Net.Socket.IdleSocketTimeSaving histogram (Closed)
Patch Set: self review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/socket_test_util.h ('k') | net/socket/socks_client_socket_pool.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socket_test_util.cc
diff --git a/net/socket/socket_test_util.cc b/net/socket/socket_test_util.cc
index ef21477adc6b9e7f54b0cdc032f16d34ef74427c..5c88168485e28caa5f6fb407594c6386c28c0f3d 100644
--- a/net/socket/socket_test_util.cc
+++ b/net/socket/socket_test_util.cc
@@ -22,7 +22,6 @@
#include "net/base/address_list.h"
#include "net/base/auth.h"
#include "net/base/ip_address.h"
-#include "net/base/load_timing_info.h"
#include "net/http/http_network_session.h"
#include "net/http/http_request_headers.h"
#include "net/http/http_response_headers.h"
@@ -1663,7 +1662,8 @@ void MockTransportClientSocketPool::CancelRequest(const std::string& group_name,
void MockTransportClientSocketPool::ReleaseSocket(
const std::string& group_name,
std::unique_ptr<StreamSocket> socket,
- int id) {
+ int id,
+ const LoadTimingInfo::ConnectTiming& connect_timing) {
EXPECT_EQ(1, id);
release_count_++;
}
@@ -1703,8 +1703,10 @@ void MockSOCKSClientSocketPool::CancelRequest(
void MockSOCKSClientSocketPool::ReleaseSocket(
const std::string& group_name,
std::unique_ptr<StreamSocket> socket,
- int id) {
- return transport_pool_->ReleaseSocket(group_name, std::move(socket), id);
+ int id,
+ const LoadTimingInfo::ConnectTiming& connect_timing) {
+ return transport_pool_->ReleaseSocket(group_name, std::move(socket), id,
+ connect_timing);
}
ScopedWebSocketEndpointZeroUnlockDelay::
« no previous file with comments | « net/socket/socket_test_util.h ('k') | net/socket/socks_client_socket_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698