Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: net/socket/client_socket_pool.h

Issue 2533063002: Fix Net.Socket.IdleSocketTimeSaving histogram (Closed)
Patch Set: self review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/client_socket_handle.cc ('k') | net/socket/client_socket_pool_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_pool.h
diff --git a/net/socket/client_socket_pool.h b/net/socket/client_socket_pool.h
index 15dbe5f02d6e09d6e503c6dccb4eab0a268e4949..97ed9a35d896a4ad4c24e85930e1712bb99435af 100644
--- a/net/socket/client_socket_pool.h
+++ b/net/socket/client_socket_pool.h
@@ -14,6 +14,7 @@
#include "base/time/time.h"
#include "net/base/completion_callback.h"
#include "net/base/load_states.h"
+#include "net/base/load_timing_info.h"
#include "net/base/net_export.h"
#include "net/base/request_priority.h"
#include "net/dns/host_resolver.h"
@@ -138,10 +139,13 @@ class NET_EXPORT ClientSocketPool : public LowerLayeredPool {
// Otherwise, the StreamSocket is destroyed. |id| is used to differentiate
// between updated versions of the same pool instance. The pool's id will
// change when it flushes, so it can use this |id| to discard sockets with
- // mismatched ids.
- virtual void ReleaseSocket(const std::string& group_name,
- std::unique_ptr<StreamSocket> socket,
- int id) = 0;
+ // mismatched ids. |connect_timing| contains timing info of the connection
+ // establishment.
+ virtual void ReleaseSocket(
+ const std::string& group_name,
+ std::unique_ptr<StreamSocket> socket,
+ int id,
+ const LoadTimingInfo::ConnectTiming& connect_timing) = 0;
// This flushes all state from the ClientSocketPool. This means that all
// idle and connecting sockets are discarded with the given |error|.
« no previous file with comments | « net/socket/client_socket_handle.cc ('k') | net/socket/client_socket_pool_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698