Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 2533063002: Fix Net.Socket.IdleSocketTimeSaving histogram (Closed)
Patch Set: self review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_proxy_client_socket_pool.cc ('k') | net/socket/client_socket_handle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_unittest.cc
diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc
index 9ea8df492aa43761889b4caeea35f66c7f7f098f..94004385b88d382966781c6f825fd24b7b0733eb 100644
--- a/net/http/http_stream_factory_impl_unittest.cc
+++ b/net/http/http_stream_factory_impl_unittest.cc
@@ -15,6 +15,7 @@
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
+#include "net/base/load_timing_info.h"
#include "net/base/port_util.h"
#include "net/base/test_completion_callback.h"
#include "net/base/test_proxy_delegate.h"
@@ -408,9 +409,11 @@ class CapturePreconnectsSocketPool : public ParentPool {
ClientSocketHandle* handle) override {
ADD_FAILURE();
}
- void ReleaseSocket(const std::string& group_name,
- std::unique_ptr<StreamSocket> socket,
- int id) override {
+ void ReleaseSocket(
+ const std::string& group_name,
+ std::unique_ptr<StreamSocket> socket,
+ int id,
+ const LoadTimingInfo::ConnectTiming& connect_timing) override {
ADD_FAILURE();
}
void CloseIdleSockets() override { ADD_FAILURE(); }
« no previous file with comments | « net/http/http_proxy_client_socket_pool.cc ('k') | net/socket/client_socket_handle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698