AnalysisErrorWithProperties cannot be reported with the new analysis driver.

AnalysisErrorWithProperties cannot be reported with the new analysis driver.

Add a check for now to avoid crashes.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/1fea2bb2385712f19fa7cfbf84cbafc4b482d90c

[Paul Berry, 2016-11-28 18:41:35]

lgtm

https://codereview.chromium.org/2533043002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/2533043002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:290: if (error
is AnalysisErrorWithProperties) {
Would you mind adding a "TODO" comment to remind us of the issue this is working
around?

[scheglov, 2016-11-28 18:43:53]

Description was changed from

==========
AnalysisErrorWithProperties cannot be reported with the new analysis driver.

Add a check for now to avoid crashes.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
AnalysisErrorWithProperties cannot be reported with the new analysis driver.

Add a check for now to avoid crashes.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/1fea2bb2385712f19fa7cfbf84cbafc4b482d90c
==========

[scheglov, 2016-11-28 18:43:54]

Committed patchset #1 (id:1) manually as
1fea2bb2385712f19fa7cfbf84cbafc4b482d90c (presubmit successful).

[scheglov, 2016-11-28 18:44:13]

https://codereview.chromium.org/2533043002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/2533043002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:290: if (error
is AnalysisErrorWithProperties) {
On 2016/11/28 18:41:35, Paul Berry wrote:
> Would you mind adding a "TODO" comment to remind us of the issue this is
working
> around?

Done.

[Brian Wilkerson, 2016-11-28 18:53:54]

lgtm