Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 253303003: Revert of Enable VK overscroll by default. (Closed)

Created:
6 years, 7 months ago by Nikita (slow)
Modified:
6 years, 7 months ago
Reviewers:
bshe, kevers
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Enable VK overscroll by default. (https://codereview.chromium.org/260413002/) Reason for revert: Speculative revert, suspecting that it breaks ash_unittests. http://goo.gl/ZxoISj http://goo.gl/RlD70H Original issue's description: > Enable VK overscroll by default. > > BUG=242933 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267115 TBR=bshe@chromium.org,kevers@chromium.org NOTREECHECKS=true NOTRY=true BUG=242933 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/keyboard/keyboard_util.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nikita (slow)
Created Revert of Enable VK overscroll by default.
6 years, 7 months ago (2014-04-30 09:53:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/253303003/1
6 years, 7 months ago (2014-04-30 09:53:43 UTC) #2
commit-bot: I haz the power
Change committed as 267150
6 years, 7 months ago (2014-04-30 09:54:14 UTC) #3
Nikita (slow)
6 years, 7 months ago (2014-04-30 10:33:24 UTC) #4
Message was sent while issue was closed.
This was indeed the test failure caused by this CL
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

Powered by Google App Engine
This is Rietveld 408576698