third_party/WebKit/Source/core/dom/Element.h - Issue 2532983004: Re-work <dialog>#show*() focus algorithm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.h

Issue 2532983004: Re-work <dialog>#show*() focus algorithm (Closed)

Patch Set: starting to mess with tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.h

diff --git a/third_party/WebKit/Source/core/dom/Element.h b/third_party/WebKit/Source/core/dom/Element.h

index 750f24249cce3a8f99f382c4896e140eb54f9ebd..7e9e0f1f3fe221109850e5f3b13fdda0a3b808c4 100644

--- a/third_party/WebKit/Source/core/dom/Element.h

+++ b/third_party/WebKit/Source/core/dom/Element.h

@@ -773,6 +773,8 @@ class CORE_EXPORT Element : public ContainerNode {

// TODO(tkent): Rename this to isFocusableStyle.

virtual bool layoutObjectIsFocusable() const;

+ bool hasTabIndex() const { return hasElementFlag(TabIndexWasSetExplicitly); }

// classAttributeChanged() exists to share code between

// parseAttribute (called via setAttribute()) and

// svgAttributeChanged (called when element.className.baseValue is set)