third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/inert-label-focus.html - Issue 2532983004: Re-work <dialog>#show*() focus algorithm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/inert-label-focus.html

Issue 2532983004: Re-work <dialog>#show*() focus algorithm (Closed)

Patch Set: starting to mess with tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/inert-label-focus.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/inert-label-focus.html b/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/inert-label-focus.html

index f98cc72f0b3c98014788f0b7240a4a6f7c6091c8..6b59a844b985bbc42d49c86c7cb47851888fde75 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/inert-label-focus.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/inert-label-focus.html

@@ -38,7 +38,7 @@ label.focus();

shouldBe('document.activeElement', "document.querySelector('#submit')");

debug('Testing that clicking on the label sends focus to document.body.');

-clickOn(label);

+clickOn(label); // this now focuses the dialog instead

shouldBe('document.activeElement', 'document.body');

</script>

</html>

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/inert-node-is-unfocusable.html » ('j') | no next file with comments »