third_party/WebKit/Source/core/html/HTMLDialogElement.h - Issue 2532983004: Re-work <dialog>#show*() focus algorithm

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLDialogElement.h

Issue 2532983004: Re-work <dialog>#show*() focus algorithm (Closed)

Patch Set: starting to mess with tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 private:	66 private:

67 explicit HTMLDialogElement(Document&);	67 explicit HTMLDialogElement(Document&);

68	68

69 bool isPresentationAttribute(const QualifiedName&) const override;	69 bool isPresentationAttribute(const QualifiedName&) const override;

70 void defaultEventHandler(Event*) override;	70 void defaultEventHandler(Event*) override;

71	71

72 void forceLayoutForCentering();	72 void forceLayoutForCentering();

73	73

74 void scheduleCloseEvent();	74 void scheduleCloseEvent();

75	75

	76 bool supportsFocus() const final;

	77 int tabIndex() const final;

	78

76 CenteringMode m_centeringMode;	79 CenteringMode m_centeringMode;

77 LayoutUnit m_centeredPosition;	80 LayoutUnit m_centeredPosition;

78 String m_returnValue;	81 String m_returnValue;

79 };	82 };

80	83

81 } // namespace blink	84 } // namespace blink

82	85

83 #endif // HTMLDialogElement_h	86 #endif // HTMLDialogElement_h

OLD	NEW

« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.h ('k') | third_party/WebKit/Source/core/html/HTMLDialogElement.cpp » ('j') | no next file with comments »