third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/inert-node-is-unfocusable.html - Issue 2532983004: Re-work <dialog>#show*() focus algorithm

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/inert-node-is-unfocusable.html

Issue 2532983004: Re-work <dialog>#show*() focus algorithm (Closed)

Patch Set: starting to mess with tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/inert-label-focus.html ('k') | third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/show-modal-focusing-steps.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../../resources/js-test.js"></script>	4 <script src="../../../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body id="body" tabindex="1">	6 <body id="body" tabindex="1">

7 <dialog id="top-dialog" tabindex="1" style="width: 100px; top: 30px"><button id= "top-dialog-button">I get focus</button></dialog>	7 <dialog id="top-dialog" tabindex="1" style="width: 100px; top: 30px"><button id= "top-dialog-button">I get focus</button></dialog>

8 <dialog id="bottom-dialog" tabindex="-1" style="width: 100px; bottom: 30px"><but ton id="bottom-dialog-button">I don't get focus.</button></dialog>	8 <dialog id="bottom-dialog" tabindex="-1" style="width: 100px; bottom: 30px"><but ton id="bottom-dialog-button">I don't get focus.</button></dialog>

9 <div id="container">	9 <div id="container">

10 <input id="text" type="text">	10 <input id="text" type="text">

(...skipping 30 matching lines...) Expand all Loading...
41 testTree(childNodes[i], expectFocus);	41 testTree(childNodes[i], expectFocus);

42 }	42 }

43	43

44 var bottomDialog = document.getElementById('bottom-dialog');	44 var bottomDialog = document.getElementById('bottom-dialog');

45 bottomDialog.showModal();	45 bottomDialog.showModal();

46	46

47 var topDialog = document.getElementById('top-dialog');	47 var topDialog = document.getElementById('top-dialog');

48 topDialog.showModal();	48 topDialog.showModal();

49	49

50 testFocus(document.body, false);	50 testFocus(document.body, false);

51 testTree(topDialog, true);	51 testTree(topDialog, true); // this breaks

52 testTree(bottomDialog, false);	52 testTree(bottomDialog, false);

53 testTree(document.getElementById('container'), false);	53 testTree(document.getElementById('container'), false);

54 </script>	54 </script>

55 </body>	55 </body>

56 </html>	56 </html>

OLD	NEW