Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2532953004: Enable read-only access to initializing formals (issue 27895) (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable read-only access to initializing formals (issue 27895) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7e067a6fc8933b99585c1cf6c49f184014ea745f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -38 lines) Patch
M pkg/analyzer/lib/src/command_line/arguments.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 4 chunks +8 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 3 chunks +1 line, -9 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/simple_resolver_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/command_line/arguments_test.dart View 3 chunks +0 lines, -3 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years ago (2016-11-29 00:52:53 UTC) #2
scheglov
LGTM
4 years ago (2016-11-29 01:14:48 UTC) #3
Brian Wilkerson
4 years ago (2016-11-29 15:46:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7e067a6fc8933b99585c1cf6c49f184014ea745f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698