[Android NTP] Reduce API surface of NewTabPageAdapter.

[Android NTP] Reduce API surface of NewTabPageAdapter.

Remove:
* getSignInPromoPosition()
* getSuggestionPosition()

Change to default visibility:
* getBottomSpacerPosition()
* getLastContentItemPosition()

Change to private:
* hasAllBeenDismissed()
* getSuggestionsSection()
* getChildPositionOffset()

Two methods are added for tests:
* getSectionForTesting()
* getRootForTesting()

BUG=616090
Committed: https://crrev.com/6c65a58be01cfe2b054752b29f4b393887441e6d
Cr-Commit-Position: refs/heads/master@{#436327}

[Bernhard Bauer, 2016-11-28 14:45:27]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 14:45:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 15:14:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 15:14:12]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-11-29 14:18:10]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 14:18:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 14:52:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 14:52:04]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-11-29 14:57:42]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 14:57:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-11-29 15:03:31]

Description was changed from

==========
[Android NTP] Reduce API surface of NewTabPageAdapter.

BUG=616090
==========

to

==========
[Android NTP] Reduce API surface of NewTabPageAdapter.

Remove:
* getSignInPromoPosition()
* getSuggestionPosition()

Change to default visibility:
* getBottomSpacerPosition()
* getLastContentItemPosition()

Change to private:
* hasAllBeenDismissed()
* getSuggestionsSection()
* getChildPositionOffset()

Two methods are added for tests:
* getSectionForTesting()
* getRootForTesting()

BUG=616090
==========

[Bernhard Bauer, 2016-11-29 15:06:37]

bauerb@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Bernhard Bauer, 2016-11-29 15:06:39]

Please review :)

[commit-bot: I haz the power, 2016-11-29 15:30:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 15:30:59]

Dry run: This issue passed the CQ dry run.

[Michael van Ouwerkerk, 2016-12-05 13:40:50]

lgtm

https://codereview.chromium.org/2532953002/diff/120001/chrome/android/junit/s...
File
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
(right):

https://codereview.chromium.org/2532953002/diff/120001/chrome/android/junit/s...
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:210:
private void reloadNtp() {
Maybe move the private helpers to the bottom of the file?

https://codereview.chromium.org/2532953002/diff/120001/chrome/android/junit/s...
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:763:
private boolean isSignInPromoVisible() {
Maybe move the private helpers to the bottom of the file?

[Bernhard Bauer, 2016-12-05 16:15:24]

Thanks!

https://codereview.chromium.org/2532953002/diff/120001/chrome/android/junit/s...
File
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
(right):

https://codereview.chromium.org/2532953002/diff/120001/chrome/android/junit/s...
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:210:
private void reloadNtp() {
On 2016/12/05 13:40:50, Michael van Ouwerkerk wrote:
> Maybe move the private helpers to the bottom of the file?

Done.

https://codereview.chromium.org/2532953002/diff/120001/chrome/android/junit/s...
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:763:
private boolean isSignInPromoVisible() {
On 2016/12/05 13:40:50, Michael van Ouwerkerk wrote:
> Maybe move the private helpers to the bottom of the file?

Done.

[Bernhard Bauer, 2016-12-05 16:16:16]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2016-12-05 16:16:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/2532953002/#ps140001
(title: "move")

[commit-bot: I haz the power, 2016-12-05 16:16:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 17:06:38]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1480954576571930,
"parent_rev": "5a741722534e71de07322f7904b30c6385d80ece", "commit_rev":
"57dd05c42bfe334ef8617736e8ff55968a5fa891"}

[commit-bot: I haz the power, 2016-12-05 17:07:04]

Description was changed from

==========
[Android NTP] Reduce API surface of NewTabPageAdapter.

Remove:
* getSignInPromoPosition()
* getSuggestionPosition()

Change to default visibility:
* getBottomSpacerPosition()
* getLastContentItemPosition()

Change to private:
* hasAllBeenDismissed()
* getSuggestionsSection()
* getChildPositionOffset()

Two methods are added for tests:
* getSectionForTesting()
* getRootForTesting()

BUG=616090
==========

to

==========
[Android NTP] Reduce API surface of NewTabPageAdapter.

Remove:
* getSignInPromoPosition()
* getSuggestionPosition()

Change to default visibility:
* getBottomSpacerPosition()
* getLastContentItemPosition()

Change to private:
* hasAllBeenDismissed()
* getSuggestionsSection()
* getChildPositionOffset()

Two methods are added for tests:
* getSectionForTesting()
* getRootForTesting()

BUG=616090
==========

[commit-bot: I haz the power, 2016-12-05 17:07:05]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-12-05 17:08:42]

Description was changed from

==========
[Android NTP] Reduce API surface of NewTabPageAdapter.

Remove:
* getSignInPromoPosition()
* getSuggestionPosition()

Change to default visibility:
* getBottomSpacerPosition()
* getLastContentItemPosition()

Change to private:
* hasAllBeenDismissed()
* getSuggestionsSection()
* getChildPositionOffset()

Two methods are added for tests:
* getSectionForTesting()
* getRootForTesting()

BUG=616090
==========

to

==========
[Android NTP] Reduce API surface of NewTabPageAdapter.

Remove:
* getSignInPromoPosition()
* getSuggestionPosition()

Change to default visibility:
* getBottomSpacerPosition()
* getLastContentItemPosition()

Change to private:
* hasAllBeenDismissed()
* getSuggestionsSection()
* getChildPositionOffset()

Two methods are added for tests:
* getSectionForTesting()
* getRootForTesting()

BUG=616090

Committed: https://crrev.com/6c65a58be01cfe2b054752b29f4b393887441e6d
Cr-Commit-Position: refs/heads/master@{#436327}
==========

[commit-bot: I haz the power, 2016-12-05 17:08:43]

Patchset 8 (id:??) landed as
https://crrev.com/6c65a58be01cfe2b054752b29f4b393887441e6d
Cr-Commit-Position: refs/heads/master@{#436327}