Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2532943003: Allow public WebViewDatabaseAdapter methods (Closed)

Created:
4 years ago by Nate Fischer
Modified:
3 years, 12 months ago
Reviewers:
sgurun-gerrit only
CC:
agrieve+watch_chromium.org, android-webview-reviews_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow public WebViewDatabaseAdapter methods Don't let proguard remove WebViewDatabaseAdapter methods, since these are used in Android cts tests. BUG=649816 Committed: https://crrev.com/2aebde7c5a3ee73dd28bb301b725eb1490a48c36 Cr-Commit-Position: refs/heads/master@{#434896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M android_webview/apk/java/proguard.flags View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Nate Fischer
4 years ago (2016-11-29 03:04:24 UTC) #3
sgurun-gerrit only
On 2016/11/29 03:04:24, Nate Fischer wrote: lgtm
4 years ago (2016-11-29 03:21:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532943003/1
4 years ago (2016-11-29 04:00:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 04:49:22 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-29 04:52:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2aebde7c5a3ee73dd28bb301b725eb1490a48c36
Cr-Commit-Position: refs/heads/master@{#434896}

Powered by Google App Engine
This is Rietveld 408576698