Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 253293003: Replace heap object access macros with functions and move them to the heap class (Closed)

Created:
6 years, 7 months ago by Jarin
Modified:
4 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Replace heap object access macros with functions and move them to the heap class BUG=

Patch Set 1 #

Total comments: 2

Patch Set 2 : Switched to V8_INLINE, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+569 lines, -449 lines) Patch
M src/heap.h View 1 2 chunks +62 lines, -1 line 0 comments Download
M src/heap-inl.h View 1 2 chunks +167 lines, -5 lines 0 comments Download
M src/objects-inl.h View 91 chunks +340 lines, -443 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Hannes Payer (out of office)
6 years, 7 months ago (2014-04-30 07:47:25 UTC) #1
I think this is going in the right direction, cool stuff.

If performance is not *significantly* negatively impacted we should get rid of
the macros.

https://codereview.chromium.org/253293003/diff/1/src/heap.h
File src/heap.h (right):

https://codereview.chromium.org/253293003/diff/1/src/heap.h#newcode686
src/heap.h:686: static inline Object* read_field(HeapObject* p, int offset);
Our INLINE macro may force inlining of these functions.

https://codereview.chromium.org/253293003/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/253293003/diff/1/src/objects-inl.h#newcode99
src/objects-inl.h:99: #define SYNCHRONIZED_SMI_ACCESSORS(holder, name, offset)  
 \
The synchronized accessors should also live in heap, i.e., all methods using
them should be part of heap.

Powered by Google App Engine
This is Rietveld 408576698