Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2532913002: Unreverting Embedding-CSP: Refactoring directive strings into enum. (Closed)

Created:
4 years ago by amalika
Modified:
4 years ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unreverting Embedding-CSP: Refactoring directive strings into enum. Removing ASSERT_DEATH. Origin Review-Url: https://codereview.chromium.org/2516383002 Reverted: https://codereview.chromium.org/2528133002/ BUG=647588 Committed: https://crrev.com/de04a02a5064714447a890c08f92c36d0d82488a Cr-Commit-Position: refs/heads/master@{#434655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -233 lines) Patch
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h View 3 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 28 chunks +115 lines, -94 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h View 5 chunks +30 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 12 chunks +129 lines, -90 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp View 1 chunk +47 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
amalika
4 years ago (2016-11-28 12:45:50 UTC) #4
Mike West
LGTM.
4 years ago (2016-11-28 13:00:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532913002/1
4 years ago (2016-11-28 14:23:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 14:27:22 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-28 14:29:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de04a02a5064714447a890c08f92c36d0d82488a
Cr-Commit-Position: refs/heads/master@{#434655}

Powered by Google App Engine
This is Rietveld 408576698