Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2532893002: [debug] remove debug command processor from debug evaluate tests. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] remove debug command processor from debug evaluate tests. R=jgruber@chromium.org BUG=v8:5510 Committed: https://crrev.com/e1470db7a34f93b52ebc45ab608d17472978d92d Cr-Commit-Position: refs/heads/master@{#41308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -196 lines) Patch
M test/debugger/test-api.js View 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/debug-evaluate.js View 1 chunk +10 lines, -79 lines 0 comments Download
M test/mjsunit/debug-evaluate-bool-constructor.js View 1 chunk +5 lines, -20 lines 0 comments Download
M test/mjsunit/debug-evaluate-recursive.js View 2 chunks +0 lines, -51 lines 0 comments Download
M test/mjsunit/debug-evaluate-with-context.js View 3 chunks +20 lines, -45 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
4 years ago (2016-11-28 10:56:18 UTC) #1
jgruber
lgtm
4 years ago (2016-11-28 11:10:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532893002/1
4 years ago (2016-11-28 11:12:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 11:38:07 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-28 11:38:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1470db7a34f93b52ebc45ab608d17472978d92d
Cr-Commit-Position: refs/heads/master@{#41308}

Powered by Google App Engine
This is Rietveld 408576698