Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2532883002: binding: Removes unused toV8 functions. (Closed)

Created:
4 years ago by Yuki
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Removes unused toV8 functions. toV8({PassRefPtr,RefPtr}) is no longer used after the migration to Oilpan. Removes them. BUG= Committed: https://crrev.com/ddf0ab63df2d97a1a923e5475eaaae17619b0454 Cr-Commit-Position: refs/heads/master@{#434639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ToV8.h View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Yuki
4 years ago (2016-11-28 09:48:14 UTC) #4
haraken
LGTM
4 years ago (2016-11-28 10:23:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532883002/1
4 years ago (2016-11-28 12:06:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 12:10:51 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-28 12:12:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddf0ab63df2d97a1a923e5475eaaae17619b0454
Cr-Commit-Position: refs/heads/master@{#434639}

Powered by Google App Engine
This is Rietveld 408576698