Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2532873002: Get rid of wrong assumption in reconcileTextDecorationProperties() (Closed)

Created:
4 years ago by yosin_UTC9
Modified:
4 years ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of wrong assumption in reconcileTextDecorationProperties() This patch gets rid of |DCHECK()|, which is a wrong assumption, in |reconcileTextDecorationProperties()| since we have a test case against the assumption. BUG=663613 TEST=LayoutTests/editing/execCommand/insert-list-and-strikethrough.html Committed: https://crrev.com/a9814d2d1bbc0c1d77dad4f2619e21e28757b47f Cr-Commit-Position: refs/heads/master@{#434857}

Patch Set 1 : 2016-11-28T18:40:32 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/editing/execCommand/insert-list-and-strikethrough.html View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
yosin_UTC9
PTAL
4 years ago (2016-11-29 01:07:56 UTC) #8
Xiaocheng
lgtm
4 years ago (2016-11-29 01:53:16 UTC) #9
yoichio
lgtm
4 years ago (2016-11-29 01:54:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532873002/1
4 years ago (2016-11-29 02:06:44 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 03:05:32 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-29 03:11:10 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9814d2d1bbc0c1d77dad4f2619e21e28757b47f
Cr-Commit-Position: refs/heads/master@{#434857}

Powered by Google App Engine
This is Rietveld 408576698