Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2532843002:
Postpone DOM mutation event in Range::extractContents() (Closed)
|
Created:
4 years ago by yosin_UTC9 Modified:
4 years ago Reviewers:
tkent CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPostpone DOM mutation event in Range::extractContents()
This patch makes |Range::extractContents()| to postpone DOM mutation event
dispatching just before returning value rather than updating C++ variables
which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(),
Node::removeChild(), etc., to avoid running JavaScript code during in
|extractContents()| for simplicity.
For executing script in |RangeTest|, this patch makes |RangeTest| class to
derived from |EditingTestBase|.
This patch removes
"fast/dom/Range/range-created-in-mutation-event-crash.xhtml" since it causes
script error by calling |Range#getBoundingClientRect()| with |null| value and
coverage of this test is as same as newly added gTest.
This patch is similar to http://crrev.com/199383004 which makes
|Range::deleteContents()| to postpone DOM mutation event.
BUG=642537
TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent
Committed: https://crrev.com/e19337b440249f853e44e2df4912236e07b60803
Cr-Commit-Position: refs/heads/master@{#434848}
Patch Set 1 : 2016-11-28T16:37:50 #Patch Set 2 : 2016-11-28T18:02:27 #
Messages
Total messages: 24 (18 generated)
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== 2016-11-28T16:37:50 BUG= ========== to ========== Postpone DOM mutation event in Range::extractContents() This patch makes |Range::extractContents()| to postpone DOM mutation event dispatching just before returning value rather than updating C++ variables which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(), Node::removeChild(), etc., to avoid running JavaScript code during C++ DOM mutation. This patch is similar to http://crrev.com/199383004 which makes |Range::deleteContents()| to postpone DOM mutation event. BUG=642537 TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent ==========
Description was changed from ========== Postpone DOM mutation event in Range::extractContents() This patch makes |Range::extractContents()| to postpone DOM mutation event dispatching just before returning value rather than updating C++ variables which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(), Node::removeChild(), etc., to avoid running JavaScript code during C++ DOM mutation. This patch is similar to http://crrev.com/199383004 which makes |Range::deleteContents()| to postpone DOM mutation event. BUG=642537 TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent ========== to ========== Postpone DOM mutation event in Range::extractContents() This patch makes |Range::extractContents()| to postpone DOM mutation event dispatching just before returning value rather than updating C++ variables which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(), Node::removeChild(), etc., to avoid running JavaScript code during in |extractContents()| for simplicity. This patch is similar to http://crrev.com/199383004 which makes |Range::deleteContents()| to postpone DOM mutation event. BUG=642537 TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent ==========
Description was changed from ========== Postpone DOM mutation event in Range::extractContents() This patch makes |Range::extractContents()| to postpone DOM mutation event dispatching just before returning value rather than updating C++ variables which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(), Node::removeChild(), etc., to avoid running JavaScript code during in |extractContents()| for simplicity. This patch is similar to http://crrev.com/199383004 which makes |Range::deleteContents()| to postpone DOM mutation event. BUG=642537 TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent ========== to ========== Postpone DOM mutation event in Range::extractContents() This patch makes |Range::extractContents()| to postpone DOM mutation event dispatching just before returning value rather than updating C++ variables which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(), Node::removeChild(), etc., to avoid running JavaScript code during in |extractContents()| for simplicity. For executing script in |RangeText|, this patch makes |RangeTest| class to derived from |EditingTestBase|. This patch is similar to http://crrev.com/199383004 which makes |Range::deleteContents()| to postpone DOM mutation event. BUG=642537 TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Postpone DOM mutation event in Range::extractContents() This patch makes |Range::extractContents()| to postpone DOM mutation event dispatching just before returning value rather than updating C++ variables which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(), Node::removeChild(), etc., to avoid running JavaScript code during in |extractContents()| for simplicity. For executing script in |RangeText|, this patch makes |RangeTest| class to derived from |EditingTestBase|. This patch is similar to http://crrev.com/199383004 which makes |Range::deleteContents()| to postpone DOM mutation event. BUG=642537 TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent ========== to ========== Postpone DOM mutation event in Range::extractContents() This patch makes |Range::extractContents()| to postpone DOM mutation event dispatching just before returning value rather than updating C++ variables which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(), Node::removeChild(), etc., to avoid running JavaScript code during in |extractContents()| for simplicity. For executing script in |RangeText|, this patch makes |RangeTest| class to derived from |EditingTestBase|. This patch removes "fast/dom/Range/range-created-in-mutation-event-crash.xhtml" since it causes script error by calling |Range#getBoundingClientRect()| with |null| value and coverage of this test is as same as newly added gTest. This patch is similar to http://crrev.com/199383004 which makes |Range::deleteContents()| to postpone DOM mutation event. BUG=642537 TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent ==========
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Postpone DOM mutation event in Range::extractContents() This patch makes |Range::extractContents()| to postpone DOM mutation event dispatching just before returning value rather than updating C++ variables which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(), Node::removeChild(), etc., to avoid running JavaScript code during in |extractContents()| for simplicity. For executing script in |RangeText|, this patch makes |RangeTest| class to derived from |EditingTestBase|. This patch removes "fast/dom/Range/range-created-in-mutation-event-crash.xhtml" since it causes script error by calling |Range#getBoundingClientRect()| with |null| value and coverage of this test is as same as newly added gTest. This patch is similar to http://crrev.com/199383004 which makes |Range::deleteContents()| to postpone DOM mutation event. BUG=642537 TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent ========== to ========== Postpone DOM mutation event in Range::extractContents() This patch makes |Range::extractContents()| to postpone DOM mutation event dispatching just before returning value rather than updating C++ variables which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(), Node::removeChild(), etc., to avoid running JavaScript code during in |extractContents()| for simplicity. For executing script in |RangeText|, this patch makes |RangeTest| class to derived from |EditingTestBase|. This patch removes "fast/dom/Range/range-created-in-mutation-event-crash.xhtml" since it causes script error by calling |Range#getBoundingClientRect()| with |null| value and coverage of this test is as same as newly added gTest. This patch is similar to http://crrev.com/199383004 which makes |Range::deleteContents()| to postpone DOM mutation event. BUG=642537 TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent ==========
yosin@chromium.org changed reviewers: + tkent@chromium.org
PTAL
lgtm. CL description: > For executing script in |RangeText|, this patch makes |RangeTest| class to RangeText -> RangeTest?
Description was changed from ========== Postpone DOM mutation event in Range::extractContents() This patch makes |Range::extractContents()| to postpone DOM mutation event dispatching just before returning value rather than updating C++ variables which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(), Node::removeChild(), etc., to avoid running JavaScript code during in |extractContents()| for simplicity. For executing script in |RangeText|, this patch makes |RangeTest| class to derived from |EditingTestBase|. This patch removes "fast/dom/Range/range-created-in-mutation-event-crash.xhtml" since it causes script error by calling |Range#getBoundingClientRect()| with |null| value and coverage of this test is as same as newly added gTest. This patch is similar to http://crrev.com/199383004 which makes |Range::deleteContents()| to postpone DOM mutation event. BUG=642537 TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent ========== to ========== Postpone DOM mutation event in Range::extractContents() This patch makes |Range::extractContents()| to postpone DOM mutation event dispatching just before returning value rather than updating C++ variables which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(), Node::removeChild(), etc., to avoid running JavaScript code during in |extractContents()| for simplicity. For executing script in |RangeTest|, this patch makes |RangeTest| class to derived from |EditingTestBase|. This patch removes "fast/dom/Range/range-created-in-mutation-event-crash.xhtml" since it causes script error by calling |Range#getBoundingClientRect()| with |null| value and coverage of this test is as same as newly added gTest. This patch is similar to http://crrev.com/199383004 which makes |Range::deleteContents()| to postpone DOM mutation event. BUG=642537 TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent ==========
On 2016/11/29 at 01:14:55, tkent wrote: > lgtm. > > CL description: > > For executing script in |RangeText|, this patch makes |RangeTest| class to > > RangeText -> RangeTest? Done. Oops.
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480385105750830,
"parent_rev": "d85f7abfc31bf755e38f6a52aaa17931c577363d", "commit_rev":
"67cd660dd85298da6ee6c895cc5de075eb087fb7"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Postpone DOM mutation event in Range::extractContents() This patch makes |Range::extractContents()| to postpone DOM mutation event dispatching just before returning value rather than updating C++ variables which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(), Node::removeChild(), etc., to avoid running JavaScript code during in |extractContents()| for simplicity. For executing script in |RangeTest|, this patch makes |RangeTest| class to derived from |EditingTestBase|. This patch removes "fast/dom/Range/range-created-in-mutation-event-crash.xhtml" since it causes script error by calling |Range#getBoundingClientRect()| with |null| value and coverage of this test is as same as newly added gTest. This patch is similar to http://crrev.com/199383004 which makes |Range::deleteContents()| to postpone DOM mutation event. BUG=642537 TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent ========== to ========== Postpone DOM mutation event in Range::extractContents() This patch makes |Range::extractContents()| to postpone DOM mutation event dispatching just before returning value rather than updating C++ variables which holds |Node*| for every DOM mutation calls, e.g. Node::appendChild(), Node::removeChild(), etc., to avoid running JavaScript code during in |extractContents()| for simplicity. For executing script in |RangeTest|, this patch makes |RangeTest| class to derived from |EditingTestBase|. This patch removes "fast/dom/Range/range-created-in-mutation-event-crash.xhtml" since it causes script error by calling |Range#getBoundingClientRect()| with |null| value and coverage of this test is as same as newly added gTest. This patch is similar to http://crrev.com/199383004 which makes |Range::deleteContents()| to postpone DOM mutation event. BUG=642537 TEST=run_webkit_unittets --gtest_filter=extractContentsWithDOMMutationEvent Committed: https://crrev.com/e19337b440249f853e44e2df4912236e07b60803 Cr-Commit-Position: refs/heads/master@{#434848} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e19337b440249f853e44e2df4912236e07b60803 Cr-Commit-Position: refs/heads/master@{#434848} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
