Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2532833002: Reflect method restriction removal from Fetch API on data URL (Closed)

Created:
4 years ago by tyoshino (SeeGerritForStatus)
Modified:
4 years ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reflect method restriction removal from Fetch API on data URL R=yhirano@chromium.org BUG=668949 Committed: https://crrev.com/d6dc64d2bb6a2260488679e4e19b8205e9e54511 Cr-Commit-Position: refs/heads/master@{#436927}

Patch Set 1 #

Patch Set 2 : a #

Patch Set 3 : a #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/fetch.js View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/scheme-data.js View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 27 (19 generated)
tyoshino (SeeGerritForStatus)
4 years ago (2016-11-28 06:44:02 UTC) #2
tyoshino (SeeGerritForStatus)
many failures... please hold on
4 years ago (2016-11-28 08:56:10 UTC) #7
tyoshino (SeeGerritForStatus)
On 2016/11/28 08:56:10, tyoshino wrote: > many failures... please hold on ready again
4 years ago (2016-11-29 02:17:19 UTC) #12
yhirano
I'm concerned about the FIXME comment in ResourceFetcher::resourceForStaticData. Are you sure it's OK? If so, ...
4 years ago (2016-11-29 04:09:06 UTC) #15
yhirano
Sorry, I misunderstood. LGTM.
4 years ago (2016-12-02 05:59:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532833002/60001
4 years ago (2016-12-07 10:51:00 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-07 12:53:19 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-07 12:55:40 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d6dc64d2bb6a2260488679e4e19b8205e9e54511
Cr-Commit-Position: refs/heads/master@{#436927}

Powered by Google App Engine
This is Rietveld 408576698