Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2532823002: Fix gendered string descriptions and comments in //components. (Closed)

Created:
4 years ago by Sam McNally
Modified:
4 years ago
Reviewers:
pastarmovj, blundell
CC:
chromium-reviews, tnagel+watch_chromium.org, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gendered string descriptions and comments in //components. BUG=542537 Committed: https://crrev.com/9084df89c77918525987293c4b8da04a5b3025fa Cr-Commit-Position: refs/heads/master@{#434647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/components_google_chrome_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M components/error_page_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download
M components/metrics/metrics_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/resources/policy_templates.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Sam McNally
+blundell for //components +pastarmovj for components/policy/resources/policy_templates.json
4 years ago (2016-11-28 06:12:22 UTC) #4
pastarmovj
lgtm
4 years ago (2016-11-28 08:14:18 UTC) #7
blundell
lgtm. Thanks for doing this!
4 years ago (2016-11-28 13:30:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532823002/1
4 years ago (2016-11-28 13:30:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 13:43:59 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-28 13:46:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9084df89c77918525987293c4b8da04a5b3025fa
Cr-Commit-Position: refs/heads/master@{#434647}

Powered by Google App Engine
This is Rietveld 408576698