Issue 2532813002: Matching part for >>> (shadow-piercing descendant combinator).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2532813002: Matching part for >>> (shadow-piercing descendant combinator). (Closed)

Created:
4 years ago by kochi

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

More Reviews

Description

Matching part for >>> (shadow-piercing descendant combinator). Parsing part is done in the previous dependent CL. https://codereview.chromium.org/2500813003/ This CL implements matching '>>>' shadow-piercing descendant combinator in static profile. Note that the combinator only pierces through open shadow roots and not V0 or closed shadow roots. BUG=633007 Review-Url: https://codereview.chromium.org/2496123002 Cr-Commit-Position: refs/heads/master@{#433457} (cherry picked from commit 04a4852c265670de8100ceee3e20215f4a56091f)

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+143 lines, -2 lines)			Patch
M	third_party/WebKit/LayoutTests/shadow-dom/query-selector.html	View	2 chunks	+16 lines, -2 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/shadow-dom/shadow-piercing-descendant-combinator.html	View	1 chunk	+72 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/shadow-dom/shadow-piercing-descendant-combinator-in-static-profile.html	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/CSSSelector.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/SelectorChecker.cpp	View	2 chunks	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

kochi

4 years ago (2016-11-28 06:02:37 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
8f69d1abfb4fcf12de6911895494f93e1406b0ed.

Expand Messages | Collapse Messages