Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 25328002: PPAPI: Remove instance param from GetFileTaskRunner (Closed)

Created:
7 years, 2 months ago by dmichael (off chromium)
Modified:
7 years, 2 months ago
Reviewers:
bbudge
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

PPAPI: Remove instance param from GetFileTaskRunner BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M content/renderer/pepper/host_globals.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/host_globals.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/file_io_resource.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/plugin_globals.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_globals.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/ppapi_globals.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/test_globals.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/test_globals.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dmichael (off chromium)
Since jam's refactor work, HostGlobals::GetFileTaskRunner no longer needs a PP_Instance parameter.
7 years, 2 months ago (2013-09-30 18:29:03 UTC) #1
bbudge
Great to see this go away. LGTM
7 years, 2 months ago (2013-09-30 18:32:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/25328002/1
7 years, 2 months ago (2013-09-30 19:05:08 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-01 06:20:52 UTC) #4
Message was sent while issue was closed.
Change committed as 226165

Powered by Google App Engine
This is Rietveld 408576698