Add a TestBrowserDialog helper class for testing browser dialogs in a consistent way.

base/test/test_timeouts.h

Index: base/test/test_timeouts.h
diff --git a/base/test/test_timeouts.h b/base/test/test_timeouts.h
index ddaf05b5e0ca583b011f19bb237817aa01a5c953..9d42eb91fe12a0de88e2cf568a30a9d174c8e60d 100644
--- a/base/test/test_timeouts.h
+++ b/base/test/test_timeouts.h
@@ -13,6 +13,9 @@
 // the timeouts for different environments (like Valgrind).
 class TestTimeouts {
  public:
+  // Argument that can be passed on the command line to indicate "no timeout".
+  static constexpr const char kNoTimeoutSwitchValue[] = "-1";

[jam, 2016/12/20 00:17:57]

Why do we need this, given that there are already switches to set the timeout
high?

[Peter Kasting, 2016/12/20 00:24:23]

There's only a switch to set the timeout to a specific value.  The original CL
tried to pick a large value, but picked a different large value than other
places in the code.  In general, this seemed error-prone, and I asked for a way
to disable the timeout entirely.  Implementing this looked complicated, and so
was filed as a bug, with a compromise implemented here to basically treat -1 as
"disabled".

[tapted, 2016/12/20 00:25:17]

This is from the review comment at
https://codereview.chromium.org/2532793002/diff/160001/chrome/browser/ui/test...

See also http://crbug.com/674764 filed from that comment

+
   // Initializes the timeouts. Non thread-safe. Should be called exactly once
   // by the test suite.
   static void Initialize();