components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc - Issue 2532783003: [NTP] Translateable strings for recent tabs and physical web sections.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

Issue 2532783003: [NTP] Translateable strings for recent tabs and physical web sections. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc » ('j') | components/ntp_snippets_strings.grdp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

diff --git a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

index 8323590f2cabcfe0ac43ae28c910b5d3524eec30..747f7ace39c0cb16ba09b850de38b44e81f1707b 100644

--- a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

+++ b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

@@ -109,9 +109,7 @@ CategoryInfo RecentTabSuggestionsProvider::GetCategoryInfo(Category category) {

/*has_reload_action=*/false,

/*has_view_all_action=*/false,

/*show_if_empty=*/false,

- l10n_util::GetStringUTF16(IDS_NTP_SUGGESTIONS_SECTION_EMPTY));

- // TODO(vitaliii): Replace IDS_NTP_SUGGESTIONS_SECTION_EMPTY with a

- // category-specific string.

+ l10n_util::GetStringUTF16(IDS_NTP_RECENT_TAB_SUGGESTIONS_SECTION_EMPTY));

}

void RecentTabSuggestionsProvider::DismissSuggestion(

« no previous file with comments | « no previous file | components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc » ('j') | components/ntp_snippets_strings.grdp » ('J')