Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2532693002: [debug-wrapper] AsyncTaskEvent event type (Closed)

Created:
4 years ago by jgruber
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug-wrapper] AsyncTaskEvent event type AsyncTaskEvents are not exposed through the inspector interface. BUG=v8:5530 Committed: https://crrev.com/a61585e9b2408ac6d0ee662e172f022e9b066f06 Cr-Commit-Position: refs/heads/master@{#41299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -162 lines) Patch
D test/debugger/debug/es6/debug-promises/async-task-event.js View 1 chunk +0 lines, -62 lines 0 comments Download
M test/debugger/debug/es6/debug-promises/throw-uncaught-uncaught.js View 1 chunk +0 lines, -1 line 0 comments Download
D test/debugger/debug/harmony/debug-async-function-async-task-event.js View 1 chunk +0 lines, -97 lines 0 comments Download
M test/debugger/test-api.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jgruber
Inspector handles AsyncTaskEvents internally. WDYT about removing these two tests and not exposing AsyncTaskEvent through ...
4 years ago (2016-11-25 12:28:10 UTC) #4
Yang
On 2016/11/25 12:28:10, jgruber wrote: > Inspector handles AsyncTaskEvents internally. WDYT about removing these two ...
4 years ago (2016-11-28 08:58:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532693002/1
4 years ago (2016-11-28 09:04:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 09:31:43 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-28 09:31:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a61585e9b2408ac6d0ee662e172f022e9b066f06
Cr-Commit-Position: refs/heads/master@{#41299}

Powered by Google App Engine
This is Rietveld 408576698