Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 2532653002: Revert of Disable dromaeo.jslibmodifyjquery on Windows (Closed)

Created:
4 years ago by Michael Lippautz
Modified:
4 years ago
Reviewers:
sullivan, fmeawad
CC:
chromium-reviews, telemetry-reviews_chromium.org, nednguyen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable dromaeo.jslibmodifyjquery on Windows (patchset #1 id:1 of https://codereview.chromium.org/2529673003/ ) Reason for revert: Re-enable tests as we fixed a problem with wrapper tracing. Original issue's description: > Disable dromaeo.jslibmodifyjquery on Windows > > R=sullivan@chromium.org > BUG=668164 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq > > Committed: https://crrev.com/98679f8f94d5beb4b7a0715edef85f8ba250f34b > Cr-Commit-Position: refs/heads/master@{#434268} TBR=sullivan@chromium.org,fmeawad@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=668164 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/d74a3000970f43efa51287a3f7f5931abdfa1437 Cr-Commit-Position: refs/heads/master@{#434704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tools/perf/benchmarks/dromaeo.py View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Michael Lippautz
Created Revert of Disable dromaeo.jslibmodifyjquery on Windows
4 years ago (2016-11-25 09:40:50 UTC) #1
sullivan
lgtm Thanks!
4 years ago (2016-11-28 16:04:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532653002/1
4 years ago (2016-11-28 16:04:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 18:42:52 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d74a3000970f43efa51287a3f7f5931abdfa1437 Cr-Commit-Position: refs/heads/master@{#434704}
4 years ago (2016-11-28 18:47:33 UTC) #14
Michael Lippautz
4 years ago (2016-12-07 10:11:46 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2557513006/ by mlippautz@chromium.org.

The reason for reverting is: Still failing with wrapper tracing. Investigating..

Powered by Google App Engine
This is Rietveld 408576698