MacViews: fix bubble direction in RTL.

ui/views/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 import("//ui/ozone/ozone.gni")
 
 config("flags") {
@@ skipping 603 matching lines @@
           "widget/desktop_aura/desktop_window_tree_host_ozone.cc",
         ]
       }
       if (is_linux) {
         sources += [ "style/platform_style_linux.cc" ]
       }
     }
   }
 
   if (is_mac) {
+    if (mac_views_browser) {

[sky, 2016/11/28 16:22:22]

Why does whether the browser uses views influence the direction?

Assuming that is valid I would prefer not to have files with the names you list
here. Can platform_style.cc and platform_style_mac handled the conditionals?
Does mac_views_browser map to a buildflag? If not, can it?

[tapted, 2016/11/29 06:43:54]

We never implemented proper RTL support for the Cocoa browser window :/. There
is `--enable-features=ExperimentalMacRTL` but it currently just flips the tab
strip and window frame. Flipping the toolbar is a tougher prospect (hopefully we
will switch straight to a toolkit-views browser for that).

So, e.g. for RTL on Mac, the bookmark star, extensions, etc. all remain on the
right, and the padlock remains on the left. This accounts for all the bubbles we
care about right now. (an exception would be the profile switcher - it should
open to the right in RTL, but we haven't ported that to toolkit-views).

This means that if we _do_ flip the bubble direction, the bubble opens towards
the outside of the browser window, rather than towards the inside of the browser
window.
It doesn't currently have a BUILDFLAG. I've added one (Done.).

There are some downsides of that (I've been resisting it for a while..), but
they're no longer as bad as the old #ifdef approach, so I guess I'm sold it it
:).

+      sources += [ "style/platform_style_mac_views_browser.mm" ]
+    } else {
+      sources += [ "style/platform_style_mac_cocoa_browser.mm" ]
+    }
+
     deps += [
       "//ui/accelerated_widget_mac",
       "//ui/events:dom_keycode_converter",
     ]
     libs = [
       "AppKit.framework",
       "CoreGraphics.framework",
       "Foundation.framework",
       "QuartzCore.framework",  # Required by bridged_native_widget.mm.
     ]
@@ skipping 381 matching lines @@
       "//ui/base:test_support",
       "//ui/compositor",
       "//ui/events:test_support",
       "//ui/gl:test_support",
       "//ui/resources",
       "//ui/resources:ui_test_pak",
       "//ui/strings",
     ]
   }
 }