Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2532603002:
Removing self.Fails of browser pixel tests from pixel_expectations.py. (Closed)
|
Created:
4 years ago by zakerinasab Modified:
4 years ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemoving self.Fails of browser pixel tests from pixel_expectations.py.
As all the results on cloud storage bucket are as expected, we can
remove the self.Fails lines from pixel_expectations.py.
BUG=657946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/7bf0f77ad5b4b7413ca1e11ed9683983239bc2f2
Cr-Commit-Position: refs/heads/master@{#435152}
Patch Set 1 #
Messages
Total messages: 21 (13 generated)
Description was changed from ========== Removing self.Fails of browser pixel tests from pixel_expectations.py. As all the results on cloud storage bucket are as expected, we can remove the self.Fails lines from pixel_expectations.py. BUG=657946 ========== to ========== Removing self.Fails of browser pixel tests from pixel_expectations.py. As all the results on cloud storage bucket are as expected, we can remove the self.Fails lines from pixel_expectations.py. BUG=657946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Description was changed from ========== Removing self.Fails of browser pixel tests from pixel_expectations.py. As all the results on cloud storage bucket are as expected, we can remove the self.Fails lines from pixel_expectations.py. BUG=657946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Removing self.Fails of browser pixel tests from pixel_expectations.py. As all the results on cloud storage bucket are as expected, we can remove the self.Fails lines from pixel_expectations.py. BUG=657946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
zakerinasab@chromium.org changed reviewers: + kbr@chromium.org
Sorry for the delay replying. This came in during the Thanksgiving break and I'm still catching up. Please feel free to send changes like this through a full dry run. The Blink trybots won't catch changes to these expectations files. win_chromium_rel_ng, linux_chromium_rel_ng, and mac_chromium_rel_ng are the main trybots which run these tests; the optional bots are also useful, in particular Android. I'm going to send this through a dry run. Please post on this CL once it's done.
The CQ bit was checked by kbr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
This looks good so I'll CQ it for you.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Argh, sorry - lgtm.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480487768858920, "parent_rev":
"3bd401d25e2e0cf5c63021985f46078dede2141e", "commit_rev":
"08a70a9cd963d9b05aa8d94c265182920356e6b7"}
Message was sent while issue was closed.
Description was changed from ========== Removing self.Fails of browser pixel tests from pixel_expectations.py. As all the results on cloud storage bucket are as expected, we can remove the self.Fails lines from pixel_expectations.py. BUG=657946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Removing self.Fails of browser pixel tests from pixel_expectations.py. As all the results on cloud storage bucket are as expected, we can remove the self.Fails lines from pixel_expectations.py. BUG=657946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Removing self.Fails of browser pixel tests from pixel_expectations.py. As all the results on cloud storage bucket are as expected, we can remove the self.Fails lines from pixel_expectations.py. BUG=657946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Removing self.Fails of browser pixel tests from pixel_expectations.py. As all the results on cloud storage bucket are as expected, we can remove the self.Fails lines from pixel_expectations.py. BUG=657946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/7bf0f77ad5b4b7413ca1e11ed9683983239bc2f2 Cr-Commit-Position: refs/heads/master@{#435152} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7bf0f77ad5b4b7413ca1e11ed9683983239bc2f2 Cr-Commit-Position: refs/heads/master@{#435152} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
