Position a float before laying it out.

Position a float before laying it out.

We'll no longer perform inaccurate layout from insertFloatingObject(), but
defer all layout to positionAndLayoutFloat(). We need to do this correctly
everywhere. One crucial thing is also to pay attention to the resulting
pagination strut before the float, if any. There's only one place where we do
this, and that's in positionAndLayoutFloat().

At most call sites, insertFloatingObject() is followed by a call to
placeNewFloats(), which will call positionAndLayoutFloat(). There are
exceptions to this in line layout, though. In some cases we just insert floats
without laying them out and placing them. This happens when we need to figure
out the height of the current line before we can place floats below it. In
order to figure out if a float fits on the current line, though, we first need
to lay it out without marking it as placed.

We lacked some test coverage, so I added
float-pushed-to-next-fragmentainer-by-floats.html . This also passed prior to
this CL, but I nearly broke it while working on this.

BUG=663942
Committed: https://crrev.com/596aa530f12f7777ec6336c891930a5c6770fad4
Cr-Commit-Position: refs/heads/master@{#434969}

[mstensho (USE GERRIT), 2016-11-25 13:06:13]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 13:06:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 14:13:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 14:13:41]

Dry run: This issue passed the CQ dry run.

[mstensho (USE GERRIT), 2016-11-25 14:16:42]

mstensho@opera.com changed reviewers:
+ szager@chromium.org

[szager1, 2016-11-29 01:04:34]

lgtm

[mstensho (USE GERRIT), 2016-11-29 11:45:16]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-11-29 11:45:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 13:10:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480419916582050, "parent_rev":
"86d0443c23341a5705e66f82ca6763e99b69daa5", "commit_rev":
"460fb0c4442add3deb78e281d3c77ecc7b4a1601"}

[commit-bot: I haz the power, 2016-11-29 13:10:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-29 13:14:28]

Description was changed from

==========
Position a float before laying it out.

We'll no longer perform inaccurate layout from insertFloatingObject(), but
defer all layout to positionAndLayoutFloat(). We need to do this correctly
everywhere. One crucial thing is also to pay attention to the resulting
pagination strut before the float, if any. There's only one place where we do
this, and that's in positionAndLayoutFloat().

At most call sites, insertFloatingObject() is followed by a call to
placeNewFloats(), which will call positionAndLayoutFloat(). There are
exceptions to this in line layout, though. In some cases we just insert floats
without laying them out and placing them. This happens when we need to figure
out the height of the current line before we can place floats below it. In
order to figure out if a float fits on the current line, though, we first need
to lay it out without marking it as placed.

We lacked some test coverage, so I added
float-pushed-to-next-fragmentainer-by-floats.html . This also passed prior to
this CL, but I nearly broke it while working on this.

BUG=663942
==========

to

==========
Position a float before laying it out.

We'll no longer perform inaccurate layout from insertFloatingObject(), but
defer all layout to positionAndLayoutFloat(). We need to do this correctly
everywhere. One crucial thing is also to pay attention to the resulting
pagination strut before the float, if any. There's only one place where we do
this, and that's in positionAndLayoutFloat().

At most call sites, insertFloatingObject() is followed by a call to
placeNewFloats(), which will call positionAndLayoutFloat(). There are
exceptions to this in line layout, though. In some cases we just insert floats
without laying them out and placing them. This happens when we need to figure
out the height of the current line before we can place floats below it. In
order to figure out if a float fits on the current line, though, we first need
to lay it out without marking it as placed.

We lacked some test coverage, so I added
float-pushed-to-next-fragmentainer-by-floats.html . This also passed prior to
this CL, but I nearly broke it while working on this.

BUG=663942

Committed: https://crrev.com/596aa530f12f7777ec6336c891930a5c6770fad4
Cr-Commit-Position: refs/heads/master@{#434969}
==========

[commit-bot: I haz the power, 2016-11-29 13:14:29]

Patchset 1 (id:??) landed as
https://crrev.com/596aa530f12f7777ec6336c891930a5c6770fad4
Cr-Commit-Position: refs/heads/master@{#434969}