Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2532573002: Set isSuper on accessors in no-such-method. (Closed)

Created:
4 years ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
asgerf
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/fe_integration
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Set isSuper on accessors in no-such-method. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/kernel/lib/transformations/mixin_full_resolution.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ahe
4 years ago (2016-11-24 17:12:25 UTC) #2
asgerf
LGTM (and again, please commit to pkg/kernel in the main SDK)
4 years ago (2016-11-25 09:51:29 UTC) #3
ahe
3 years, 11 months ago (2017-01-11 12:00:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9734d1c14b36c58f90e6f3f617c9e4ee55642268 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698