Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 2532563002: Revert of Presubmit: Warn about useless forward declarations (Closed)

Created:
4 years ago by dcheng
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Presubmit: Warn about useless forward declarations (patchset #1 id:1 of https://codereview.chromium.org/2525263002/ ) Reason for revert: Warning too aggressively + doesn't work with deleted files. Original issue's description: > Presubmit: Warn about useless forward declarations > > Checks that affected header files do not contain useless class > or struct forward declaration. > > BUG=662195 > TEST=PRESUBMIT_test.py ForwardDeclarationTest > > Committed: https://crrev.com/1ae91afd6ab12165d8bd7981b9984fe7aec8d3d2 > Cr-Commit-Position: refs/heads/master@{#434329} TBR=jochen@chromium.org,dpranke@google.com,phajdan.jr@chromium.org,asvitkine@chromium.org,jbriance@cisco.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=662195 Committed: https://crrev.com/10912d9e7cf31d99c99b19c94f1f076f68354c89 Cr-Commit-Position: refs/heads/master@{#434343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -84 lines) Patch
M PRESUBMIT.py View 2 chunks +0 lines, -29 lines 0 comments Download
M PRESUBMIT_test.py View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
dcheng
Created Revert of Presubmit: Warn about useless forward declarations
4 years ago (2016-11-24 16:31:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532563002/1
4 years ago (2016-11-24 16:33:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 16:34:42 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-24 16:38:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10912d9e7cf31d99c99b19c94f1f076f68354c89
Cr-Commit-Position: refs/heads/master@{#434343}

Powered by Google App Engine
This is Rietveld 408576698