Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2532543002:
Implement GetTranslatedShaderSource in the passthrough cmd decoder. (Closed)
|
Created:
4 years ago by Geoff Lang Modified:
4 years ago Reviewers:
piman CC:
chromium-reviews, piman+watch_chromium.org, Jamie Madill, Corentin Wallez Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionImplement GetTranslatedShaderSource in the passthrough cmd decoder.
Many WebGL tests use this function.
BUG=668223
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/f0cfd74ce448fa4ecef7c9b57ac4897dceea5b2c
Cr-Commit-Position: refs/heads/master@{#434877}
Patch Set 1 #
Messages
Total messages: 18 (13 generated)
Description was changed from ========== Implement GetTranslatedShaderSource in the passthrough cmd decoder. Many WebGL tests use this function. BUG=668223 ========== to ========== Implement GetTranslatedShaderSource in the passthrough cmd decoder. Many WebGL tests use this function. BUG=668223 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
geofflang@chromium.org changed reviewers: + piman@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by geofflang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480383780020420, "parent_rev":
"347df43c3b67bfa8407dfc16dcc943fc9468bbcc", "commit_rev":
"ce1b4dc082c27f751eb3189ab4ef2970c8eb5c1e"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Implement GetTranslatedShaderSource in the passthrough cmd decoder. Many WebGL tests use this function. BUG=668223 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Implement GetTranslatedShaderSource in the passthrough cmd decoder. Many WebGL tests use this function. BUG=668223 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/f0cfd74ce448fa4ecef7c9b57ac4897dceea5b2c Cr-Commit-Position: refs/heads/master@{#434877} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f0cfd74ce448fa4ecef7c9b57ac4897dceea5b2c Cr-Commit-Position: refs/heads/master@{#434877} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
