Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2532533002: [ObjC ARC] Converts ios/chrome/browser/first_run:first_run to ARC.Automatically generated ARCMigr… (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/first_run:first_run to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/d66f0fed724f3eff65201ae8e132713ea3b4b726 Cr-Commit-Position: refs/heads/master@{#436269}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ios/chrome/browser/first_run/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/first_run/first_run.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/first_run/first_run_configuration.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
stkhapugin
PTAL, passes downstream tests.
4 years ago (2016-11-25 09:49:55 UTC) #6
noyau (Ping after 24h)
lgtm
4 years ago (2016-11-25 10:06:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532533002/1
4 years ago (2016-11-25 14:40:40 UTC) #9
commit-bot: I haz the power
Failed to apply patch for ios/chrome/browser/first_run/first_run_configuration.mm: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-11-25 15:00:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532533002/20001
4 years ago (2016-12-05 11:59:00 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 12:48:56 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-05 12:51:58 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d66f0fed724f3eff65201ae8e132713ea3b4b726
Cr-Commit-Position: refs/heads/master@{#436269}

Powered by Google App Engine
This is Rietveld 408576698