Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2532513002: base: Make CHECK great again

Created:
4 years ago by Primiano Tucci (use gerrit)
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Make CHECK great again cat args.gn: is_component_build = false is_debug = false is_official_build = true 0:000> uf check_example!DoBlinkCheck check_example!DoBaseCheck [d:\src\chrome\src\base\check_example.cc @ 32]: 32 00007ff6`107a58e4 84c9 test cl,cl 33 00007ff6`107a58e6 7507 jne check_example!DoBaseCheck+0xb (00007ff6`107a58ef) Branch 33 00007ff6`107a58e8 880c2500000000 mov byte ptr [0],cl 34 00007ff6`107a58ef c3 ret Branch 0:000> uf check_example!DoBaseCheck 32 00007ff6`107a58e4 84c9 test cl,cl 33 00007ff6`107a58e6 7507 jne check_example!DoBaseCheck+0xb (00007ff6`107a58ef) Branch 33 00007ff6`107a58e8 880c2500000000 mov byte ptr [0],cl 34 00007ff6`107a58ef c3 ret Branch

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M base/check_example.cc View 1 2 chunks +15 lines, -1 line 0 comments Download
M base/logging.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (6 generated)
Primiano Tucci (use gerrit)
Description was changed from ========== NOT FOR REVIEW - CHECK BUG= ========== to ========== NOT ...
4 years ago (2016-11-24 15:32:52 UTC) #1
Primiano Tucci (use gerrit)
Description was changed from ========== NOT FOR REVIEW - Test CHECK on WIN/MSVC cat args.gn: ...
4 years ago (2016-12-09 18:24:51 UTC) #2
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org to run a CQ dry run
4 years ago (2016-12-09 18:25:21 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532513002/20001
4 years ago (2016-12-09 18:26:08 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-09 19:04:14 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-09 19:04:15 UTC) #6
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698