Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: ipc/ipc_channel_reader.h

Issue 25325002: workaround for mac kernel bug (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: minor bugfix Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_channel_posix.cc ('k') | ipc/ipc_channel_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_reader.h
diff --git a/ipc/ipc_channel_reader.h b/ipc/ipc_channel_reader.h
index 9c398bdce356791f6ba8e22e9174c5c989d190b4..130384659fc2fe9c146e2237058f93c5cb0da512 100644
--- a/ipc/ipc_channel_reader.h
+++ b/ipc/ipc_channel_reader.h
@@ -42,8 +42,12 @@ class ChannelReader {
// data. See ReadData for more.
bool AsyncReadComplete(int bytes_read);
- // Returns true if the given message is the "hello" message sent on channel
- // set-up.
+ // Returns true if the given message is internal to the IPC implementation,
+ // like the "hello" message sent on channel set-up.
+ bool IsInternalMessage(const Message& m) const;
+
+ // Returns true if the given message is an Hello message
+ // sent on channel set-up.
bool IsHelloMessage(const Message& m) const;
protected:
@@ -76,8 +80,8 @@ class ChannelReader {
// though there could be more data ready to be read from the OS.
virtual bool DidEmptyInputBuffers() = 0;
- // Handles the first message sent over the pipe which contains setup info.
- virtual void HandleHelloMessage(const Message& msg) = 0;
+ // Handles internal messages, like the hello message sent on channel startup.
+ virtual void HandleInternalMessage(const Message& msg) = 0;
private:
// Takes the given data received from the IPC channel and dispatches any
« no previous file with comments | « ipc/ipc_channel_posix.cc ('k') | ipc/ipc_channel_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698