Chromium Code Reviews| Index: ipc/ipc_channel.h |
| diff --git a/ipc/ipc_channel.h b/ipc/ipc_channel.h |
| index f65a62b9cc9ee4fda212d66b513f76c60737ba9c..f0d4fd9c8f486b49fd11a80be5550db4300d17c0 100644 |
| --- a/ipc/ipc_channel.h |
| +++ b/ipc/ipc_channel.h |
| @@ -75,15 +75,24 @@ class IPC_EXPORT Channel : public Sender { |
| #endif |
| }; |
| - // The Hello message is internal to the Channel class. It is sent |
| - // by the peer when the channel is connected. The message contains |
| - // just the process id (pid). The message has a special routing_id |
| - // (MSG_ROUTING_NONE) and type (HELLO_MESSAGE_TYPE). |
| + // Messages internal to the IPC implementation are defined here. |
| enum { |
| - HELLO_MESSAGE_TYPE = kuint16max // Maximum value of message type (uint16), |
| + // The Hello message is sent by the peer when the channel is connected. |
| + // The message contains just the process id (pid). |
| + // The message has a special routing_id (MSG_ROUTING_NONE) |
| + // and type (HELLO_MESSAGE_TYPE). |
| + HELLO_MESSAGE_TYPE = kuint16max, // Maximum value of message type (uint16), |
|
agl
2013/10/09 21:52:38
// lines misaligned.
hubbe
2013/10/09 21:59:40
better?
|
| // to avoid conflicting with normal |
| // message types, which are enumeration |
| // constants starting from 0. |
| + |
| + // The CLOSE_FD_MESSAGE_TYPE is used in the IPC class to |
| + // work around a bug in sendmsg() on Mac. When an FD is sent |
| + // over the socket, a CLOSE_FD_MESSAGE is sent with hops = 2. |
| + // The client will return the message with hops = 1, *after* it |
| + // has received the message that contains the FD. When we |
| + // receive it again on the sender side, we close the FD. |
| + CLOSE_FD_MESSAGE_TYPE = HELLO_MESSAGE_TYPE - 1 |
| }; |
| // The maximum message size in bytes. Attempting to receive a message of this |