ipc/ipc_channel_win.cc - Issue 25325002: workaround for mac kernel bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_win.cc

Issue 25325002: workaround for mac kernel bug (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test now actually triggers kernel bug, auto-flush CloseFD messages Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_channel_win.cc

diff --git a/ipc/ipc_channel_win.cc b/ipc/ipc_channel_win.cc

index 6d7cfe8d3f4d7feecc7c96d188e779eefaad7ac0..7fbcf35f573df48324954d741f1ecd32b925ae6f 100644

--- a/ipc/ipc_channel_win.cc

+++ b/ipc/ipc_channel_win.cc

@@ -152,7 +152,8 @@ bool Channel::ChannelImpl::WillDispatchInputMessage(Message* msg) {

return true;

}

-void Channel::ChannelImpl::HandleHelloMessage(const Message& msg) {

+void Channel::ChannelImpl::HandleInternalMessage(const Message& msg) {

+ DCHECK_EQ(msg.type(), Channel::HELLO_MESSAGE_TYPE);

// The hello message contains one parameter containing the PID.

PickleIterator it(msg);

int32 claimed_pid;